• Maya Lekova's avatar
    Revert "[turbofan] extend type asserts to cover all JS types" · 54f90462
    Maya Lekova authored
    This reverts commit 45227ffd.
    
    Reason for revert: Breaks on gc_stress mode, see https://ci.chromium.org/ui/p/v8/builders/ci/V8%20Linux%20-%20gc%20stress/35988/overview
    
    Original change's description:
    > [turbofan] extend type asserts to cover all JS types
    >
    > Extend type assertions to all types covering JavaScript values.
    > This is achieved by allocating type representations on the heap using
    > newly defined HeapObject subclasses. To allocate these in the compiler,
    > we disable concurrent compilation for the --assert-types flag for now.
    >
    > Fix two type errors that came up with the existing tests:
    > 1. JSCreateKeyValueArray has type Array (i.e., a JSArray) instead of
    >    OtherObject.
    > 2. OperationTyper::NumberToString(Type) can type the result as the
    >    HeapConstant Factory::zero_string(). However, NumberToString does
    >    not always produce this string. To avoid regressions, the CL keeps
    >    the HeapConstant type and changes the runtime and builtin code to
    >    always produce the canonical "0" string.
    >
    > A few tests were failing because they check for truncations to work
    > and prevent deoptimization. However, AssertType nodes destroy all
    > truncations (which is by design), so these tests are incompatible
    > and now disabled for the assert_types variant.
    >
    > Drive-by fix: a few minor Torque issues that came up.
    >
    > Change-Id: If03b7851f7e6803a2f69edead4fa91231998f764
    > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3234717
    > Reviewed-by: Nico Hartmann <nicohartmann@chromium.org>
    > Reviewed-by: Omer Katz <omerkatz@chromium.org>
    > Commit-Queue: Tobias Tebbi <tebbi@chromium.org>
    > Cr-Commit-Position: refs/heads/main@{#77565}
    
    Change-Id: Ia779a11fc811846194c7a8d1e40b372b265e7ea4
    No-Presubmit: true
    No-Tree-Checks: true
    No-Try: true
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3247034
    Auto-Submit: Maya Lekova <mslekova@chromium.org>
    Owners-Override: Maya Lekova <mslekova@chromium.org>
    Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
    Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/main@{#77566}
    54f90462
Name
Last commit
Last update
..
arm Loading commit data...
arm64 Loading commit data...
ia32 Loading commit data...
loong64 Loading commit data...
mips Loading commit data...
mips64 Loading commit data...
ppc Loading commit data...
riscv64 Loading commit data...
s390 Loading commit data...
x64 Loading commit data...
DEPS Loading commit data...
OWNERS Loading commit data...
basic-block-profiler.cc Loading commit data...
basic-block-profiler.h Loading commit data...
code-tracer.h Loading commit data...
compilation-statistics.cc Loading commit data...
compilation-statistics.h Loading commit data...
disasm.h Loading commit data...
disassembler.cc Loading commit data...
disassembler.h Loading commit data...
eh-frame.cc Loading commit data...
eh-frame.h Loading commit data...
gdb-jit.cc Loading commit data...
gdb-jit.h Loading commit data...
objects-debug.cc Loading commit data...
objects-printer.cc Loading commit data...
perf-jit.cc Loading commit data...
perf-jit.h Loading commit data...
system-jit-metadata-win.h Loading commit data...
system-jit-win.cc Loading commit data...
system-jit-win.h Loading commit data...
unwinder.cc Loading commit data...
unwinder.h Loading commit data...
unwinding-info-win64.cc Loading commit data...
unwinding-info-win64.h Loading commit data...