• vogelheim's avatar
    Revert of Re-land "Fix double-building of v8 in GN builds" (patchset #2... · 54f663e2
    vogelheim authored
    Revert of Re-land "Fix double-building of v8 in GN builds" (patchset #2 id:20001 of https://codereview.chromium.org/2171083003/ )
    
    Reason for revert:
    Reverted, because it breaks some funky android build.
    
    Can reproduce breakage locally, w/ args.gn as follows:
    disable_brotli_filter = true
    disable_file_support = true
    disable_ftp_support = true
    enable_websockets = false
    ffmpeg_branding = "Chrome"
    is_component_build = false
    is_debug = true
    proprietary_codecs = true
    symbol_level = 1
    target_cpu = "x86"
    target_os = "android"
    use_goma = true
    use_platform_icu_alternatives = true
    
    This ends up building the mkpeephole tool w/ an architecture that won't run on the build machine.
    
    Original issue's description:
    > Re-land "Fix double-building of v8 in GN builds"
    >
    > This re-lands r37926 w/ the needed fix for cross-compiles; we
    > can only re-use the default toolchain when the host can actually
    > run it.
    >
    > R=machenbach@chromium.org
    > BUG=629825
    >
    > Committed: https://crrev.com/5b762044b53f988fa9a534fe1a84f9938b3abd75
    > Cr-Commit-Position: refs/heads/master@{#37970}
    
    TBR=machenbach@chromium.org,dpranke@chromium.org
    # Skipping CQ checks because original CL landed less than 1 days ago.
    NOPRESUBMIT=true
    NOTREECHECKS=true
    NOTRY=true
    BUG=629825
    
    Review-Url: https://codereview.chromium.org/2175693003
    Cr-Commit-Position: refs/heads/master@{#37984}
    54f663e2
Name
Last commit
Last update
benchmarks Loading commit data...
build_overrides Loading commit data...
docs Loading commit data...
gni Loading commit data...
gypfiles Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party/binutils Loading commit data...
tools Loading commit data...
.clang-format Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
ChangeLog Loading commit data...
DEPS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
LICENSE.valgrind Loading commit data...
Makefile Loading commit data...
Makefile.android Loading commit data...
Makefile.nacl Loading commit data...
OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
WATCHLISTS Loading commit data...
codereview.settings Loading commit data...
snapshot_toolchain.gni Loading commit data...