• Seth Brenith's avatar
    Allow no-op background merges to complete · 890ee74c
    Seth Brenith authored
    It is possible, though unlikely, that V8 will deserialize code cache
    data, decide to merge that new data with an existing script from the
    Isolate compilation cache, and subsequently do nothing in the background
    portion of the merge (make no heap changes, and request no follow-up
    changes on the main thread). In this case, the most optimal outcome is
    to reuse the script from the Isolate compilation cache, not to use the
    newly deserialized script.
    
    CodeSerializer::FinishOffThreadDeserialize uses
    BackgroundMergeTask::HasPendingForegroundWork to determine whether it
    should complete the merge and use the Script from the compilation cache
    or complete the deserialization and use the newly deserialized Script.
    This change updates HasPendingForegroundWork so that it will return true
    even if the merge was a no-op.
    
    Bug: v8:12808
    Change-Id: I08fcb814e797218e5be2b4ce4f45bd4e0637ec80
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3916270
    Commit-Queue: Seth Brenith <seth.brenith@microsoft.com>
    Reviewed-by: 's avatarLeszek Swirski <leszeks@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#83439}
    890ee74c
Name
Last commit
Last update
..
api Loading commit data...
asmjs Loading commit data...
assembler Loading commit data...
base Loading commit data...
codegen Loading commit data...
compiler Loading commit data...
compiler-dispatcher Loading commit data...
date Loading commit data...
debug Loading commit data...
deoptimizer Loading commit data...
diagnostics Loading commit data...
execution Loading commit data...
flags Loading commit data...
heap Loading commit data...
inspector Loading commit data...
interpreter Loading commit data...
js-atomics Loading commit data...
libplatform Loading commit data...
libsampler Loading commit data...
logging Loading commit data...
numbers Loading commit data...
objects Loading commit data...
parser Loading commit data...
profiler Loading commit data...
regexp Loading commit data...
regress Loading commit data...
runtime Loading commit data...
sandbox Loading commit data...
strings Loading commit data...
tasks Loading commit data...
temporal Loading commit data...
torque Loading commit data...
tracing Loading commit data...
utils Loading commit data...
wasm Loading commit data...
web-snapshot Loading commit data...
zone Loading commit data...
BUILD.gn Loading commit data...
DEPS Loading commit data...
avoid-windows-h-includes.cc Loading commit data...
gay-fixed.cc Loading commit data...
gay-fixed.h Loading commit data...
gay-precision.cc Loading commit data...
gay-precision.h Loading commit data...
gay-shortest.cc Loading commit data...
gay-shortest.h Loading commit data...
run-all-unittests.cc Loading commit data...
test-helpers.cc Loading commit data...
test-helpers.h Loading commit data...
test-utils.cc Loading commit data...
test-utils.h Loading commit data...
testcfg.py Loading commit data...
unittests.status Loading commit data...
v8_unittests.cml Loading commit data...