• Samuel Groß's avatar
    [sandbox] Fix DCHECK failure in EPT entry allocation · 541d4080
    Samuel Groß authored
    When an entry is allocated from the freelist, is is not correct to
    `DCHECK(entry.IsFreelistEntry())` before the compare-and-swap succeeds:
    another thread may have allocated the same entry in the meantime,
    thereby turning it into a regular entry. However, in that case the CAS
    will fail and then entry allocation will be retried.
    
    Drive-by: factor out the common logic from AllocateAndInitializeEntry
    and AllocateEvacuationEntry into a new TryAllocateEntryFromFreelist.
    
    Bug: v8:13246
    Change-Id: Idf16b67a2ca5ddeef16620a4d6f4a8a6c07d917b
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3865864Reviewed-by: 's avatarIgor Sheludko <ishell@chromium.org>
    Commit-Queue: Igor Sheludko <ishell@chromium.org>
    Auto-Submit: Samuel Groß <saelo@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#82868}
    541d4080
Name
Last commit
Last update
.github Loading commit data...
bazel Loading commit data...
build_overrides Loading commit data...
custom_deps Loading commit data...
docs Loading commit data...
gni Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.bazelrc Loading commit data...
.clang-format Loading commit data...
.clang-tidy Loading commit data...
.editorconfig Loading commit data...
.flake8 Loading commit data...
.git-blame-ignore-revs Loading commit data...
.gitattributes Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.mailmap Loading commit data...
.style.yapf Loading commit data...
.vpython Loading commit data...
.vpython3 Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.bazel Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
COMMON_OWNERS Loading commit data...
DEPS Loading commit data...
DIR_METADATA Loading commit data...
ENG_REVIEW_OWNERS Loading commit data...
INFRA_OWNERS Loading commit data...
INTL_OWNERS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
LOONG_OWNERS Loading commit data...
MIPS_OWNERS Loading commit data...
OWNERS Loading commit data...
PPC_OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
RISCV_OWNERS Loading commit data...
S390_OWNERS Loading commit data...
WATCHLISTS Loading commit data...
WORKSPACE Loading commit data...
codereview.settings Loading commit data...