• Georg Neis's avatar
    [flags] Print flags that were ignored. · 5330111d
    Georg Neis authored
    Command-line flags can be parsed in two modes. In the mode used by
    Chrome, an unrecognized flag causes the remaining arguments to be
    ignored. This is different from how d8 parses flags.
    
    Example:
    
    1) d8 --enable-slow-asserts --trace-ic
    2) content_shell --js-flags='--enable-slow-asserts --trace-ic'
    
    Assuming we compiled without ENABLE_SLOW_DCHECKS, in (1) we get a
    warning that --enable-slow-asserts is unknown. Nevertheless,
    --trace-ic will be enabled. In (2), we get an error that
    --enable-slow-asserts is unknown but --trace-ic will NOT be enabled
    (and neither does content_shell abort).
    
    This inconsistency is obviously very confusing. With this CL, we
    will at least print any flags that got ignored.
    
    Change-Id: I22bdb06d2b0accc234b3f5d596458809de364bce
    Reviewed-on: https://chromium-review.googlesource.com/1066010
    Commit-Queue: Georg Neis <neis@chromium.org>
    Reviewed-by: 's avatarSigurd Schneider <sigurds@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#53261}
    5330111d
Name
Last commit
Last update
benchmarks Loading commit data...
build_overrides Loading commit data...
docs Loading commit data...
gni Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.clang-format Loading commit data...
.editorconfig Loading commit data...
.git-blame-ignore-revs Loading commit data...
.gitattributes Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.vpython Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
ChangeLog Loading commit data...
DEPS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
LICENSE.valgrind Loading commit data...
OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
WATCHLISTS Loading commit data...
codereview.settings Loading commit data...
snapshot_toolchain.gni Loading commit data...