• Danil Somsikov's avatar
    Revert "Calls to {console} require an access check for the provided arguments" · 52f1d69e
    Danil Somsikov authored
    This reverts commit a5fd60e1.
    
    Reason for revert: As per crbug/1213374 this is not applied consistently. E.g. wrapping object into an array will bypass access checks. With the crrev/c/3041424 however, only accessible properties are shown in console, so logging a restricted object is no longer unsafe.
    
    Original change's description:
    > Calls to {console} require an access check for the provided arguments
    >
    > This CL adds an access check for the arguments to all calls to
    > {console} like {console.log}. This is needed since the DevTools
    > protocol notificiation event does not contain the context in which
    > the {console.log} call occurred. Only the context of the argument.
    > When DevTools then reads properties for the preview of the argument,
    > it uses arguments context, instead of the calling context, potentially
    > leaking objects/exceptions into the calling context.
    >
    > Bug: chromium:987502, chromium:986393
    > Change-Id: I6f7682f7bee94a28ac61994bad259bd003511c39
    > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1741664
    > Commit-Queue: Simon Zünd <szuend@chromium.org>
    > Reviewed-by: Yang Guo <yangguo@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#63122}
    
    Bug: chromium:987502, chromium:986393, chromium:1213374
    Change-Id: I92a8bb7663ff97de8831ddeb2c8560fb9fa1c12e
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3046189Reviewed-by: 's avatarSimon Zünd <szuend@chromium.org>
    Reviewed-by: 's avatarYang Guo <yangguo@chromium.org>
    Commit-Queue: Danil Somsikov <dsv@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#75881}
    52f1d69e
Name
Last commit
Last update
.github Loading commit data...
bazel Loading commit data...
build_overrides Loading commit data...
custom_deps Loading commit data...
docs Loading commit data...
gni Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.bazelrc Loading commit data...
.clang-format Loading commit data...
.clang-tidy Loading commit data...
.editorconfig Loading commit data...
.flake8 Loading commit data...
.git-blame-ignore-revs Loading commit data...
.gitattributes Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.mailmap Loading commit data...
.vpython Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.bazel Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
COMMON_OWNERS Loading commit data...
DEPS Loading commit data...
DIR_METADATA Loading commit data...
ENG_REVIEW_OWNERS Loading commit data...
INFRA_OWNERS Loading commit data...
INTL_OWNERS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
MIPS_OWNERS Loading commit data...
OWNERS Loading commit data...
PPC_OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
RISCV_OWNERS Loading commit data...
S390_OWNERS Loading commit data...
WATCHLISTS Loading commit data...
WORKSPACE Loading commit data...
codereview.settings Loading commit data...