• vogelheim's avatar
    Revert of Rework CallApi*Stubs. (patchset #5 id:100001 of... · 52a741d1
    vogelheim authored
    Revert of Rework CallApi*Stubs. (patchset #5 id:100001 of https://codereview.chromium.org/1748123003/ )
    
    Reason for revert:
    Breaks Chromium.
    
    Original issue's description:
    > Rework CallApi*Stubs.
    >
    > - Eliminate stubs with a variable number of arguments.
    >   (That only worked due to their very limited use. These
    >    stubs' interface descriptors were basically lying
    >    about their number of args, which will fail when used
    >    generically.)
    > - Fix all CallApi*Stubs' interface descriptors to no
    >   longer lie about their arguments.
    > - Unify CallApi*Stub, for * in Function, Accessor,
    >   FunctionWithFixedArgs.
    >   (Since these are now all doing the same thing.)
    > - Rename the unified stub (and interface descriptors) to
    >   *ApiCallback*, since that's really what they're doing.
    > - Refuse inlining an API callback if its number of
    >   parameters exceeds the supported number of args.
    >
    > BUG=
    >
    > Committed: https://crrev.com/d238b953a474272c0e3ea22ef6a9b63fa9729340
    > Cr-Commit-Position: refs/heads/master@{#34614}
    
    TBR=danno@chromium.org,jkummerow@chromium.org,mstarzinger@chromium.org
    # Skipping CQ checks because original CL landed less than 1 days ago.
    NOPRESUBMIT=true
    NOTREECHECKS=true
    NOTRY=true
    BUG=
    
    Review URL: https://codereview.chromium.org/1775933005
    
    Cr-Commit-Position: refs/heads/master@{#34624}
    52a741d1
Name
Last commit
Last update
benchmarks Loading commit data...
build Loading commit data...
docs Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party/binutils Loading commit data...
tools Loading commit data...
.clang-format Loading commit data...
.gitignore Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
ChangeLog Loading commit data...
DEPS Loading commit data...
LICENSE Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
LICENSE.valgrind Loading commit data...
Makefile Loading commit data...
Makefile.android Loading commit data...
Makefile.nacl Loading commit data...
OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
WATCHLISTS Loading commit data...
codereview.settings Loading commit data...
snapshot_toolchain.gni Loading commit data...