• Simon Zünd's avatar
    [debug] Fix crash in debug scope search · 5242128f
    Simon Zünd authored
    This CL fixes a crash when we build the scope chain after re-parsing
    for Debugger.evaluateOnCallFrame.
    
    The following script causes the crash:
    
    class A {
      test(){
        debugger;
      }
      f = (x) => {}
    }
    let a = new A()
    a.test()
    
    The current scope search tries to be smart and descends deeper
    into the scope tree based on source position. That is not a sound
    approach as V8 doesn't guarantee that sibling scopes don't overlap.
    
    In the above case V8 creates an instance initializer scope where
    f is assigned (and the initializer scope is the parent scope for
    the arrow function). The problem is that the initializer scope
    uses the same source range as the class `A` itself, so when we
    look for the scope for `test`, we descend wrongly into the
    initializer scope and can't recover.
    
    The solution is to not try and be too smart:
      - First, find the closure scope with a straight-up DFS.
      - Once we have that, descend from there and try to find the
        closest fitting scope around the break position.
    
    R=bmeurer@chromium.org, jarin@chromium.org
    
    Bug: chromium:1348186
    Change-Id: Ic5e20c4d12b3d768f76a17367dc0f87bcc73763b
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3807594Reviewed-by: 's avatarLeszek Swirski <leszeks@chromium.org>
    Commit-Queue: Simon Zünd <szuend@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#82216}
    5242128f
Name
Last commit
Last update
..
api Loading commit data...
asmjs Loading commit data...
ast Loading commit data...
base Loading commit data...
baseline Loading commit data...
bigint Loading commit data...
builtins Loading commit data...
codegen Loading commit data...
common Loading commit data...
compiler Loading commit data...
compiler-dispatcher Loading commit data...
d8 Loading commit data...
date Loading commit data...
debug Loading commit data...
deoptimizer Loading commit data...
diagnostics Loading commit data...
execution Loading commit data...
extensions Loading commit data...
flags Loading commit data...
handles Loading commit data...
heap Loading commit data...
ic Loading commit data...
init Loading commit data...
inspector Loading commit data...
interpreter Loading commit data...
json Loading commit data...
libplatform Loading commit data...
libsampler Loading commit data...
logging Loading commit data...
maglev Loading commit data...
numbers Loading commit data...
objects Loading commit data...
parsing Loading commit data...
profiler Loading commit data...
protobuf Loading commit data...
regexp Loading commit data...
roots Loading commit data...
runtime Loading commit data...
sandbox Loading commit data...
sanitizer Loading commit data...
snapshot Loading commit data...
strings Loading commit data...
tasks Loading commit data...
temporal Loading commit data...
third_party Loading commit data...
torque Loading commit data...
tracing Loading commit data...
trap-handler Loading commit data...
utils Loading commit data...
wasm Loading commit data...
web-snapshot Loading commit data...
zone Loading commit data...
DEPS Loading commit data...
DIR_METADATA Loading commit data...
OWNERS Loading commit data...