• Zhi An Ng's avatar
    Revert "[build] Separate out inspector as a shared library" · 50fb0a2f
    Zhi An Ng authored
    This reverts commit 92bfb63c.
    
    Reason for revert: Broke build https://ci.chromium.org/ui/p/v8/builders/ci/V8%20Linux%20-%20shared/43249/overview
    
    Original change's description:
    > [build] Separate out inspector as a shared library
    >
    > This makes src/inspector:inspector into a v8_component producing a
    > shared library in component builds. To enable this, all of its exported
    > are now marked with V8_INSPECTOR_EXPORT.
    >
    > This also inverts the dependency between src/inspector:inspector and
    > :v8_base_without_compiler, and instead makes d8 and some tests depend on
    > inspector rather than getting it via v8.
    >
    > As a result, the no_check_targets exclusions list in .gn is reduced.
    >
    > Ultimately embedders like chromium should depend on :v8 and optionally
    > src/inspector:inspector, but to allow that transition to occur, this
    > renames :v8 to :v8_lib and introduces a new :v8 which depends on v8 and
    > inspector. Once all embedders have changed to reflect the new structure,
    > this part can be reverted.
    >
    > Bug: v8:11917
    > Change-Id: Ia8b15f07fb15acc5e1f111b1a80248def4285fd0
    > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2999088
    > Reviewed-by: Clemens Backes <clemensb@chromium.org>
    > Reviewed-by: Michael Achenbach <machenbach@chromium.org>
    > Reviewed-by: Yang Guo <yangguo@chromium.org>
    > Commit-Queue: Dan Elphick <delphick@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#75532}
    
    Bug: v8:11917
    Change-Id: I0ed27ed95211d13b8b3438a8c0a42d577806c475
    No-Presubmit: true
    No-Tree-Checks: true
    No-Try: true
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3003452
    Auto-Submit: Zhi An Ng <zhin@chromium.org>
    Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
    Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#75533}
    50fb0a2f
Name
Last commit
Last update
.github Loading commit data...
bazel Loading commit data...
build_overrides Loading commit data...
custom_deps Loading commit data...
docs Loading commit data...
gni Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.bazelrc Loading commit data...
.clang-format Loading commit data...
.clang-tidy Loading commit data...
.editorconfig Loading commit data...
.flake8 Loading commit data...
.git-blame-ignore-revs Loading commit data...
.gitattributes Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.mailmap Loading commit data...
.vpython Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.bazel Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
COMMON_OWNERS Loading commit data...
DEPS Loading commit data...
DIR_METADATA Loading commit data...
ENG_REVIEW_OWNERS Loading commit data...
INFRA_OWNERS Loading commit data...
INTL_OWNERS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
MIPS_OWNERS Loading commit data...
OWNERS Loading commit data...
PPC_OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
RISCV_OWNERS Loading commit data...
S390_OWNERS Loading commit data...
WATCHLISTS Loading commit data...
WORKSPACE Loading commit data...
codereview.settings Loading commit data...