• Andreas Haas's avatar
    [wasm] Change the memory access offset to pointer size · 50ecc42c
    Andreas Haas authored
    TurboFan expects the offset input of a Load or Store node to be a
    pointer-size input, i.e. an int32 input on 32-bit platforms, and int64
    on 64-bit platforms. In WebAssembly we always provided 32-bit offset
    though, which caused problems when the high word of the register which
    contained the offset was not empty.
    
    With this CL we change the offset input to int64 on 64-bit platforms.
    In addition we also change the type of the memory_size_ node to int64,
    so that that we do not have to adjust the type of the memory size at
    every memory load.
    
    This CL will cause performance regressions but is necessary for
    correctness and to avoid crashes.
    
    R=titzer@chromium.org
    
    Bug: chromium:766666
    Change-Id: I5301e108d05e125258d2a06d500c1b75e91697b8
    Reviewed-on: https://chromium-review.googlesource.com/723379Reviewed-by: 's avatarBen Titzer <titzer@chromium.org>
    Commit-Queue: Andreas Haas <ahaas@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#48689}
    50ecc42c
Name
Last commit
Last update
..
benchmarks Loading commit data...
cctest Loading commit data...
common Loading commit data...
debugger Loading commit data...
fuzzer Loading commit data...
inspector Loading commit data...
intl Loading commit data...
js-perf-test Loading commit data...
memory Loading commit data...
message Loading commit data...
mjsunit Loading commit data...
mkgrokdump Loading commit data...
mozilla Loading commit data...
preparser Loading commit data...
promises-aplus Loading commit data...
test262 Loading commit data...
unittests Loading commit data...
wasm-spec-tests Loading commit data...
webkit Loading commit data...
BUILD.gn Loading commit data...
bot_default.gyp Loading commit data...
bot_default.isolate Loading commit data...
default.gyp Loading commit data...
default.isolate Loading commit data...
optimize_for_size.gyp Loading commit data...
optimize_for_size.isolate Loading commit data...
perf.gyp Loading commit data...
perf.isolate Loading commit data...