• Andreas Haas's avatar
    [wasm] Change the memory access offset to pointer size · 50ecc42c
    Andreas Haas authored
    TurboFan expects the offset input of a Load or Store node to be a
    pointer-size input, i.e. an int32 input on 32-bit platforms, and int64
    on 64-bit platforms. In WebAssembly we always provided 32-bit offset
    though, which caused problems when the high word of the register which
    contained the offset was not empty.
    
    With this CL we change the offset input to int64 on 64-bit platforms.
    In addition we also change the type of the memory_size_ node to int64,
    so that that we do not have to adjust the type of the memory size at
    every memory load.
    
    This CL will cause performance regressions but is necessary for
    correctness and to avoid crashes.
    
    R=titzer@chromium.org
    
    Bug: chromium:766666
    Change-Id: I5301e108d05e125258d2a06d500c1b75e91697b8
    Reviewed-on: https://chromium-review.googlesource.com/723379Reviewed-by: 's avatarBen Titzer <titzer@chromium.org>
    Commit-Queue: Andreas Haas <ahaas@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#48689}
    50ecc42c
Name
Last commit
Last update
benchmarks Loading commit data...
build_overrides Loading commit data...
docs Loading commit data...
gni Loading commit data...
gypfiles Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.clang-format Loading commit data...
.editorconfig Loading commit data...
.git-blame-ignore-revs Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
ChangeLog Loading commit data...
DEPS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
LICENSE.valgrind Loading commit data...
Makefile Loading commit data...
Makefile.android Loading commit data...
OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
WATCHLISTS Loading commit data...
codereview.settings Loading commit data...
snapshot_toolchain.gni Loading commit data...