• Seth Brenith's avatar
    [torque] Strict verification of abstract types · 50d474a2
    Seth Brenith authored
    Originally, the Torque-generated verifier for a field with type
    Undefined|Zero|NonNullForeign would check `f.IsUndefined() || f.IsZero()
    || f.IsNonNullForeign()`. At some point, we changed Torque so that it
    now generates the much weaker `f.IsOddball() || f.IsSmi() ||
    f.IsForeign()`. This change returns the verifiers to their initial
    precision. Mostly we can use the names of abstract types to build up the
    correct type check expression, but a few abstract types like
    PodArrayOfWasmValueType have no way that we can tell them apart from
    their parent type at runtime. It would be confusing to have a function
    Object::IsPodArrayOfWasmValueType which actually just checks whether the
    object is a ByteArray, so this change introduces a new annotation which
    allows abstract type declarations to state that they should use their
    parent type during verification.
    
    This change also adds new test cases to help avoid future regressions of
    this logic.
    
    Bug: v8:7793
    Change-Id: Ie5046d742fd45e0e0f6c2ba387d909e9f2ac6df1
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2469960Reviewed-by: 's avatarClemens Backes <clemensb@chromium.org>
    Reviewed-by: 's avatarTobias Tebbi <tebbi@chromium.org>
    Commit-Queue: Seth Brenith <seth.brenith@microsoft.com>
    Cr-Commit-Position: refs/heads/master@{#70698}
    50d474a2
Name
Last commit
Last update
..
api Loading commit data...
asmjs Loading commit data...
ast Loading commit data...
base Loading commit data...
builtins Loading commit data...
codegen Loading commit data...
common Loading commit data...
compiler Loading commit data...
compiler-dispatcher Loading commit data...
d8 Loading commit data...
date Loading commit data...
debug Loading commit data...
deoptimizer Loading commit data...
diagnostics Loading commit data...
execution Loading commit data...
extensions Loading commit data...
flags Loading commit data...
handles Loading commit data...
heap Loading commit data...
ic Loading commit data...
init Loading commit data...
inspector Loading commit data...
interpreter Loading commit data...
json Loading commit data...
libplatform Loading commit data...
libsampler Loading commit data...
logging Loading commit data...
numbers Loading commit data...
objects Loading commit data...
parsing Loading commit data...
profiler Loading commit data...
protobuf Loading commit data...
regexp Loading commit data...
roots Loading commit data...
runtime Loading commit data...
sanitizer Loading commit data...
snapshot Loading commit data...
strings Loading commit data...
tasks Loading commit data...
third_party Loading commit data...
torque Loading commit data...
tracing Loading commit data...
trap-handler Loading commit data...
utils Loading commit data...
wasm Loading commit data...
zone Loading commit data...
DEPS Loading commit data...
DIR_METADATA Loading commit data...
OWNERS Loading commit data...