• Mathias Bynens's avatar
    [inspector] Improve regular expression printing · 50be01b2
    Mathias Bynens authored
    Prior to this patch, `new RegExp('a/b')` logs the following in
    the DevTools Console:
    
        /a/b/
    
    This is syntactically invalid.
    
    This patch fixes this while simplifying regular expression printing
    in general by leveraging `RegExp#toString`, instead of duplicating
    the logic on the inspector side. This is possible thanks to the recent
    work on making `RegExp#toString` more robust (v8:1982).
    
    Bug: chromium:1202013, v8:1982
    Change-Id: I14ccc1892f4a99361ad170fea608ace630740991
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2848463
    Commit-Queue: Mathias Bynens <mathias@chromium.org>
    Reviewed-by: 's avatarYang Guo <yangguo@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#74169}
    50be01b2
Name
Last commit
Last update
..
benchmarks Loading commit data...
cctest Loading commit data...
common Loading commit data...
debugger Loading commit data...
debugging Loading commit data...
fuzzer Loading commit data...
fuzzilli Loading commit data...
inspector Loading commit data...
intl Loading commit data...
js-perf-test Loading commit data...
memory Loading commit data...
message Loading commit data...
mjsunit Loading commit data...
mkgrokdump Loading commit data...
mozilla Loading commit data...
test262 Loading commit data...
torque Loading commit data...
unittests Loading commit data...
wasm-api-tests Loading commit data...
wasm-js Loading commit data...
wasm-spec-tests Loading commit data...
webkit Loading commit data...
BUILD.gn Loading commit data...
OWNERS Loading commit data...