• Mathias Bynens's avatar
    [inspector] Improve regular expression printing · 50be01b2
    Mathias Bynens authored
    Prior to this patch, `new RegExp('a/b')` logs the following in
    the DevTools Console:
    
        /a/b/
    
    This is syntactically invalid.
    
    This patch fixes this while simplifying regular expression printing
    in general by leveraging `RegExp#toString`, instead of duplicating
    the logic on the inspector side. This is possible thanks to the recent
    work on making `RegExp#toString` more robust (v8:1982).
    
    Bug: chromium:1202013, v8:1982
    Change-Id: I14ccc1892f4a99361ad170fea608ace630740991
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2848463
    Commit-Queue: Mathias Bynens <mathias@chromium.org>
    Reviewed-by: 's avatarYang Guo <yangguo@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#74169}
    50be01b2
Name
Last commit
Last update
.github Loading commit data...
build_overrides Loading commit data...
custom_deps Loading commit data...
docs Loading commit data...
gni Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.clang-format Loading commit data...
.clang-tidy Loading commit data...
.editorconfig Loading commit data...
.flake8 Loading commit data...
.git-blame-ignore-revs Loading commit data...
.gitattributes Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.vpython Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
COMMON_OWNERS Loading commit data...
DEPS Loading commit data...
DIR_METADATA Loading commit data...
ENG_REVIEW_OWNERS Loading commit data...
INFRA_OWNERS Loading commit data...
INTL_OWNERS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
MIPS_OWNERS Loading commit data...
OWNERS Loading commit data...
PPC_OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
RISCV_OWNERS Loading commit data...
S390_OWNERS Loading commit data...
WATCHLISTS Loading commit data...
codereview.settings Loading commit data...