• jgruber's avatar
    [regexp] Correct lastIndex behavior in RegExp.prototype[@@replace] · c0fe56e6
    jgruber authored
    @@replace has a pretty complex implementation, taking different paths
    for various situations (e.g.: global/nonglobal regexp, functional/string
    replace argument, etc.). Each of these paths must implement similar
    logic for calling into the RegExpBuiltinExec spec operation, and many
    paths get this subtly wrong.
    
    This CL fixes a couple of issues related to the way @@replace handles lastIndex:
    * All paths now respect lastIndex when calling into exec (some used to assume 0).
    * lastIndex is now advanced after a successful match for sticky regexps.
    * lastIndex is now only reset to 0 on failure for sticky regexps.
    
    BUG=v8:5361
    
    Review-Url: https://codereview.chromium.org/2685183003
    Cr-Commit-Position: refs/heads/master@{#43234}
    c0fe56e6
Name
Last commit
Last update
..
arm Loading commit data...
arm64 Loading commit data...
ia32 Loading commit data...
mips Loading commit data...
mips64 Loading commit data...
ppc Loading commit data...
s390 Loading commit data...
x64 Loading commit data...
x87 Loading commit data...
builtins-api.cc Loading commit data...
builtins-arguments.cc Loading commit data...
builtins-arguments.h Loading commit data...
builtins-array.cc Loading commit data...
builtins-arraybuffer.cc Loading commit data...
builtins-async-function.cc Loading commit data...
builtins-async.cc Loading commit data...
builtins-async.h Loading commit data...
builtins-boolean.cc Loading commit data...
builtins-call.cc Loading commit data...
builtins-callsite.cc Loading commit data...
builtins-constructor.cc Loading commit data...
builtins-constructor.h Loading commit data...
builtins-conversion.cc Loading commit data...
builtins-dataview.cc Loading commit data...
builtins-date.cc Loading commit data...
builtins-debug.cc Loading commit data...
builtins-error.cc Loading commit data...
builtins-function.cc Loading commit data...
builtins-generator.cc Loading commit data...
builtins-global.cc Loading commit data...
builtins-handler.cc Loading commit data...
builtins-ic.cc Loading commit data...
builtins-internal.cc Loading commit data...
builtins-interpreter.cc Loading commit data...
builtins-json.cc Loading commit data...
builtins-math.cc Loading commit data...
builtins-number.cc Loading commit data...
builtins-object.cc Loading commit data...
builtins-object.h Loading commit data...
builtins-promise.cc Loading commit data...
builtins-promise.h Loading commit data...
builtins-proxy.cc Loading commit data...
builtins-reflect.cc Loading commit data...
builtins-regexp.cc Loading commit data...
builtins-regexp.h Loading commit data...
builtins-sharedarraybuffer.cc Loading commit data...
builtins-string.cc Loading commit data...
builtins-symbol.cc Loading commit data...
builtins-typedarray.cc Loading commit data...
builtins-utils.h Loading commit data...
builtins.cc Loading commit data...
builtins.h Loading commit data...