• Dan Elphick's avatar
    [build] Improve build dependencies for gn check · 3a997519
    Dan Elphick authored
    Currently if gn check is enabled (with v8/third_party ignored), there
    are many errors due to headers being used without adding the proper
    dependency in BUILD.gn (or because it's being used transitively without
    a public_deps chain).
    
    This makes the number of errors go from 2114 to 195.
    
    Apart from adding dependencies, it also moves _v8_internal_Node_Print
    from objects-printer.cc to node.cc so it can see the Node::Print method
    which wouldn't otherwise be possible without a circular dependency. Also
    removes the previously deleted compiler/graph-builder-tester.h file.
    
    Bug: v8:7330
    Change-Id: Icb34585fbef621588265cf4267cfc88ecbcf0a72
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2702331Reviewed-by: 's avatarMichael Achenbach <machenbach@chromium.org>
    Reviewed-by: 's avatarJakob Gruber <jgruber@chromium.org>
    Commit-Queue: Dan Elphick <delphick@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#72908}
    3a997519
Name
Last commit
Last update
..
api Loading commit data...
asmjs Loading commit data...
assembler Loading commit data...
base Loading commit data...
codegen Loading commit data...
compiler Loading commit data...
compiler-dispatcher Loading commit data...
date Loading commit data...
diagnostics Loading commit data...
execution Loading commit data...
heap Loading commit data...
interpreter Loading commit data...
libplatform Loading commit data...
logging Loading commit data...
numbers Loading commit data...
objects Loading commit data...
parser Loading commit data...
profiler Loading commit data...
regress Loading commit data...
strings Loading commit data...
tasks Loading commit data...
torque Loading commit data...
utils Loading commit data...
wasm Loading commit data...
zone Loading commit data...
BUILD.gn Loading commit data...
DEPS Loading commit data...
run-all-unittests.cc Loading commit data...
test-helpers.cc Loading commit data...
test-helpers.h Loading commit data...
test-utils.cc Loading commit data...
test-utils.h Loading commit data...
testcfg.py Loading commit data...
unittests.status Loading commit data...