• Peter Marshall's avatar
    [cpu-profiler] Fix bugs and add tests for JITLineInfoTable · 4feb5ce7
    Peter Marshall authored
    Looking up line numbers with the JITLineInfoTable would sometimes give
    wrong answers. Fix these bugs and add a cctest for this data structure.
    
    Also do some cleanup while we're here like inlining the (empty)
    constructor and destructor and removing the empty() method which is
    only used unnecessarily anyway, to make the contract of
    GetSourceLineNumber a bit clearer.
    
    Also rename the data structure to SourcePositionTable, because it
    doesn't just provide info for JIT code, but also bytecode, and 'Info'
    is pretty ambiguous.
    
    Bug: v8:7018
    Change-Id: I126581c844d85df6b2b3f80f2f5acbce01c16ba1
    Reviewed-on: https://chromium-review.googlesource.com/1006795Reviewed-by: 's avatarYang Guo <yangguo@chromium.org>
    Commit-Queue: Peter Marshall <petermarshall@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#52571}
    4feb5ce7
Name
Last commit
Last update
benchmarks Loading commit data...
build_overrides Loading commit data...
docs Loading commit data...
gni Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.clang-format Loading commit data...
.editorconfig Loading commit data...
.git-blame-ignore-revs Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.vpython Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
ChangeLog Loading commit data...
DEPS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
LICENSE.valgrind Loading commit data...
OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
WATCHLISTS Loading commit data...
codereview.settings Loading commit data...
snapshot_toolchain.gni Loading commit data...