• clemensh's avatar
    [wasm] Improve pimpl implementation in WasmInterpreter::Thread · 4f91cee3
    clemensh authored
    As no one will ever try to allocate a Thread directly, we can just make
    Thread a proxy of ThreadImpl by reinterpret_casting between both types.
    This allows to not mention ThreadImpl in the header at all, and to
    define it in an anonymous namespace in the implementation, allowing for
    more optimizations.
    It also saves runtime, as no memory load is needed to forward from
    Thread to ThreadImpl, and we do not need to allocate ThreadImpl objects
    on the heap.
    
    R=titzer@chromium.org
    
    Review-Url: https://codereview.chromium.org/2643443002
    Cr-Commit-Position: refs/heads/master@{#42450}
    4f91cee3
Name
Last commit
Last update
benchmarks Loading commit data...
build_overrides Loading commit data...
docs Loading commit data...
gni Loading commit data...
gypfiles Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.clang-format Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
ChangeLog Loading commit data...
DEPS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
LICENSE.valgrind Loading commit data...
Makefile Loading commit data...
Makefile.android Loading commit data...
OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
WATCHLISTS Loading commit data...
codereview.settings Loading commit data...
snapshot_toolchain.gni Loading commit data...