• Joey Gouly's avatar
    Reland "[arm64] Cleanup TODO around handling of x18" · 4f65233f
    Joey Gouly authored
    This is a reland of 7a2651cb
    
    x18 is not allocatable nor callee-saved in v8, so stop comparing
    the before/after value in tests.
    
    Presumably the Nexus failure was due to printf on that platform
    clobbering x18.
    This can be reproduced locally by modifying `CorruptAllCallerSavedCPURegister`
    to also corrupt x18.
    
    CQ_INCLUDE_TRYBOTS=luci.v8.try:v8_android_arm64_n5x_rel_ng
    
    Original change's description:
    > [arm64] Cleanup TODO around handling of x18
    >
    > Use `padreg` instead of x18 to maintain alignment in the CPURegList.
    >
    > Also clean up some comments and tidy up RequiredStackSizeForCallerSaved
    > and PushCallerSaved.
    >
    > Change-Id: I80a780e5649e69a1746c43f37c2d1d875120c7a0
    > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1581609
    > Reviewed-by: Jakob Gruber <jgruber@chromium.org>
    > Commit-Queue: Martyn Capewell <martyn.capewell@arm.com>
    > Cr-Commit-Position: refs/heads/master@{#60987}
    
    Change-Id: I7c023a4706a98bcb9aa5acd37016a6d01e3979a6
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1583762Reviewed-by: 's avatarJakob Gruber <jgruber@chromium.org>
    Commit-Queue: Martyn Capewell <martyn.capewell@arm.com>
    Cr-Commit-Position: refs/heads/master@{#61078}
    4f65233f
Name
Last commit
Last update
benchmarks Loading commit data...
build_overrides Loading commit data...
custom_deps Loading commit data...
docs Loading commit data...
gni Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.clang-format Loading commit data...
.clang-tidy Loading commit data...
.editorconfig Loading commit data...
.git-blame-ignore-revs Loading commit data...
.gitattributes Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.vpython Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
ChangeLog Loading commit data...
DEPS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
LICENSE.valgrind Loading commit data...
OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
WATCHLISTS Loading commit data...
codereview.settings Loading commit data...
snapshot_toolchain.gni Loading commit data...