• Benedikt Meurer's avatar
    Revert "[turbofan] Optimize index checking for DataView accesses." · 4f5a6db0
    Benedikt Meurer authored
    This reverts commit 5232b938.
    
    Reason for revert: Regresses performance on the JSTests bots
    
    Original change's description:
    > [turbofan] Optimize index checking for DataView accesses.
    > 
    > Use CheckBounds and reduce the number of checks required to sanitize the
    > indices for DataView accesses in optimized code. Also constant-fold the
    > [[ByteLength]] if the DataView is a known compile-time constant (similar
    > to what we do for TypedArrays already). This further improves performance
    > of DataViews by 2-7% depending on the exact test case.
    > 
    > With this change DataView and TypedArray accesses themselves are mostly
    > on par performance wise.
    > 
    > Bug: chromium:225811
    > Change-Id: I6838339108b8a4dcf9b13ddecab40f1c3632967c
    > Reviewed-on: https://chromium-review.googlesource.com/1179741
    > Commit-Queue: Benedikt Meurer <bmeurer@chromium.org>
    > Commit-Queue: Sigurd Schneider <sigurds@chromium.org>
    > Reviewed-by: Sigurd Schneider <sigurds@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#55190}
    
    TBR=sigurds@chromium.org,bmeurer@chromium.org,mathias@chromium.org
    
    # Not skipping CQ checks because original CL landed > 1 day ago.
    
    Bug: chromium:225811
    Change-Id: I90547f91bab27127f57ba812194d3a3e3deb8ff7
    Reviewed-on: https://chromium-review.googlesource.com/1179563Reviewed-by: 's avatarBenedikt Meurer <bmeurer@chromium.org>
    Reviewed-by: 's avatarSigurd Schneider <sigurds@chromium.org>
    Commit-Queue: Benedikt Meurer <bmeurer@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#55232}
    4f5a6db0
Name
Last commit
Last update
benchmarks Loading commit data...
build_overrides Loading commit data...
custom_deps Loading commit data...
docs Loading commit data...
gni Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.clang-format Loading commit data...
.editorconfig Loading commit data...
.git-blame-ignore-revs Loading commit data...
.gitattributes Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.vpython Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
ChangeLog Loading commit data...
DEPS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
LICENSE.valgrind Loading commit data...
OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
WATCHLISTS Loading commit data...
codereview.settings Loading commit data...
snapshot_toolchain.gni Loading commit data...