• Jakob Gruber's avatar
    [execution] Only take a single lock while handling interrupts · 4e3b1874
    Jakob Gruber authored
    StackGuard::HandleInterrupts used to take a lock for testing and
    clearing each individual interrupt bit. This CL changes that to a
    single read up front.
    
    Slight behavioral changes:
    
    1. A TERMINATE_EXECUTION interrupt is now handled first; we
    immediately exit and preserve all other interrupts (in case V8 is
    later resumed).
    2. Since interrupts are read once, it is no longer possible to request
    an interrupt *within* HandleInterrupts that will later be processed
    within the same HandleInterrupts call.
    3. Stack limits are reset immediately after reading the interrupt
    bits, and prior to actually processing the interrupts.
    
    Bug: v8:9328
    Change-Id: I3048bb413213d11307df49e0014b64a2b43444e0
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1653115
    Commit-Queue: Jakob Gruber <jgruber@chromium.org>
    Reviewed-by: 's avatarYang Guo <yangguo@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#62132}
    4e3b1874
Name
Last commit
Last update
benchmarks Loading commit data...
build_overrides Loading commit data...
custom_deps Loading commit data...
docs Loading commit data...
gni Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.clang-format Loading commit data...
.clang-tidy Loading commit data...
.editorconfig Loading commit data...
.git-blame-ignore-revs Loading commit data...
.gitattributes Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.vpython Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
COMMON_OWNERS Loading commit data...
ChangeLog Loading commit data...
DEPS Loading commit data...
ENG_REVIEW_OWNERS Loading commit data...
INFRA_OWNERS Loading commit data...
INTL_OWNERS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
LICENSE.valgrind Loading commit data...
MIPS_OWNERS Loading commit data...
OWNERS Loading commit data...
PPC_OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
S390_OWNERS Loading commit data...
WATCHLISTS Loading commit data...
codereview.settings Loading commit data...