• Andreas Haas's avatar
    [wasm][ia32] Fix i64tof32 conversion on Windows · 4df3db7b
    Andreas Haas authored
    On Windows, the FP stack registers are used with less precision.
    This causes rounding errors in the uint64 to float32 conversion.
    
    This CL replaces the implementation based on FP stack registers
    with an implementation based on bit operations. This implementation
    is 2x slower than the original implementation.
    
    An alternative would be to change the precision of the FP stack
    registers just for the uint64 to float32 conversion. However, in a
    micro-benchmark this is 5-6x slower than the original implementation.
    It is also not clear if changing the precision could cause side
    effects.
    
    R=clemensh@chromium.org
    
    Change-Id: Iaab6b6f258ff01e0c6e93f3632daf516fae3e74b
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1708486
    Commit-Queue: Andreas Haas <ahaas@chromium.org>
    Reviewed-by: 's avatarClemens Hammacher <clemensh@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#62986}
    4df3db7b
Name
Last commit
Last update
benchmarks Loading commit data...
build_overrides Loading commit data...
custom_deps Loading commit data...
docs Loading commit data...
gni Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.clang-format Loading commit data...
.clang-tidy Loading commit data...
.editorconfig Loading commit data...
.flake8 Loading commit data...
.git-blame-ignore-revs Loading commit data...
.gitattributes Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.vpython Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
COMMON_OWNERS Loading commit data...
ChangeLog Loading commit data...
DEPS Loading commit data...
ENG_REVIEW_OWNERS Loading commit data...
INFRA_OWNERS Loading commit data...
INTL_OWNERS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
LICENSE.valgrind Loading commit data...
MIPS_OWNERS Loading commit data...
OWNERS Loading commit data...
PPC_OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
S390_OWNERS Loading commit data...
WATCHLISTS Loading commit data...
codereview.settings Loading commit data...