• Tom Anderson's avatar
    Avoid libc++ assert failure when building with _LIBCPP_DEBUG=0 · 4dd01774
    Tom Anderson authored
    libc++ will assert when indexing one element past the end of a vector, but V8
    uses this as the end iterator for ScopedPtrList.  Similarly, when there's no
    elements in the vector, v[0] will also assert, so ScopedPtrList::begin() needs
    to be updated too.  This CL changes ScopedPtrList to use std::vector::data() to
    get the iterators.
    
    BUG=chromium:923166
    TBR=machenbach
    
    Change-Id: Ic6a5176611d52ed592da743ecce44287c452b379
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1565543
    Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>
    Reviewed-by: 's avatarNico Weber <thakis@chromium.org>
    Auto-Submit: Thomas Anderson <thomasanderson@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#60851}
    4dd01774
Name
Last commit
Last update
benchmarks Loading commit data...
build_overrides Loading commit data...
custom_deps Loading commit data...
docs Loading commit data...
gni Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.clang-format Loading commit data...
.clang-tidy Loading commit data...
.editorconfig Loading commit data...
.git-blame-ignore-revs Loading commit data...
.gitattributes Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.vpython Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
ChangeLog Loading commit data...
DEPS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
LICENSE.valgrind Loading commit data...
OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
WATCHLISTS Loading commit data...
codereview.settings Loading commit data...
snapshot_toolchain.gni Loading commit data...