• Seth Brenith's avatar
    Revert "[torque] Support bitfield structs stored within Smis" · 4dc1fb4e
    Seth Brenith authored
    This reverts commit e5e4ea96.
    
    Reason for revert: mysterious performance regression chromium:1052756
    
    Original change's description:
    > [torque] Support bitfield structs stored within Smis
    >
    > This change moves the definition of the bits stored in DebugInfo::flags
    > to Torque, and updates the only Torque usage of that field to use more
    > natural syntax. This is intended as an example of common patterns found
    > in various other classes. Several supporting changes are required:
    >
    > 1. Add a new type representing a bitfield struct stored within a Smi. It
    >    is currently called SmiTagged, but I'm open to suggestions.
    > 2. Add an enum-style output for Torque bitfield structs whose bitfields
    >    occupy only one bit each.
    > 3. Add a new case to MachineOperatorReducer that makes the generated
    >    code for IncBlockCounter match with what was generated before this
    >    change.
    > 4. Add support for reporting these bitfields in the postmortem debugging
    >    API. The format matches existing bitfields but with an offset value
    >    that includes the SMI shift size.
    >
    > Bug: v8:7793
    > Change-Id: Icaecbe4a162da55d2d9a3a35a8ea85b285b2f1b7
    > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2028832
    > Commit-Queue: Seth Brenith <seth.brenith@microsoft.com>
    > Reviewed-by: Tobias Tebbi <tebbi@chromium.org>
    > Reviewed-by: Nico Hartmann <nicohartmann@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#66182}
    
    Bug: chromium:1052756, v8:7793
    Change-Id: I9e2897efbb6321124bf4952cf09de2f179f7310d
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2062569
    Commit-Queue: Seth Brenith <seth.brenith@microsoft.com>
    Reviewed-by: 's avatarTobias Tebbi <tebbi@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#66349}
    4dc1fb4e
Name
Last commit
Last update
build_overrides Loading commit data...
custom_deps Loading commit data...
docs Loading commit data...
gni Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.clang-format Loading commit data...
.clang-tidy Loading commit data...
.editorconfig Loading commit data...
.flake8 Loading commit data...
.git-blame-ignore-revs Loading commit data...
.gitattributes Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.vpython Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
COMMON_OWNERS Loading commit data...
DEPS Loading commit data...
ENG_REVIEW_OWNERS Loading commit data...
INFRA_OWNERS Loading commit data...
INTL_OWNERS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
LICENSE.valgrind Loading commit data...
MIPS_OWNERS Loading commit data...
OWNERS Loading commit data...
PPC_OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
S390_OWNERS Loading commit data...
WATCHLISTS Loading commit data...
codereview.settings Loading commit data...