• Seth Brenith's avatar
    [tools] Add list of classes to v8_debug_helper · 4d0360aa
    Seth Brenith authored
    This change extends v8_debug_helper to export a new method that returns
    a list of all known heap object types.
    
    Why? We can substantially improve the user experience in our work-in-
    progress WinDbg extension if we register handlers not only for
    v8::internal::Object but for every specific HeapObject type. This has
    two benefits:
    
    - You save a click: if you're expanding a local variable of a more
      specific type than Object, you can see properties immediately rather
      than first needing to expand a sub-item that casts the variable to
      Object.
    - You retain the type hint: GetObjectProperties accepts a type hint
      string, and it's super important to pass it when working in a crash
      dump because the object's Map is probably inaccessible. If we have to
      cast to Object first, we lose this data.
    
    Bug: v8:9376
    Change-Id: I4d635a1826574a3d08ac657e848e1fe7b83849fe
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1822859Reviewed-by: 's avatarTobias Tebbi <tebbi@chromium.org>
    Reviewed-by: 's avatarJakob Gruber <jgruber@chromium.org>
    Commit-Queue: Seth Brenith <seth.brenith@microsoft.com>
    Cr-Commit-Position: refs/heads/master@{#64331}
    4d0360aa
Name
Last commit
Last update
..
api Loading commit data...
asmjs Loading commit data...
ast Loading commit data...
base Loading commit data...
builtins Loading commit data...
codegen Loading commit data...
common Loading commit data...
compiler Loading commit data...
compiler-dispatcher Loading commit data...
d8 Loading commit data...
date Loading commit data...
debug Loading commit data...
deoptimizer Loading commit data...
diagnostics Loading commit data...
execution Loading commit data...
extensions Loading commit data...
flags Loading commit data...
handles Loading commit data...
heap Loading commit data...
ic Loading commit data...
init Loading commit data...
inspector Loading commit data...
interpreter Loading commit data...
json Loading commit data...
libplatform Loading commit data...
libsampler Loading commit data...
logging Loading commit data...
numbers Loading commit data...
objects Loading commit data...
parsing Loading commit data...
profiler Loading commit data...
protobuf Loading commit data...
regexp Loading commit data...
roots Loading commit data...
runtime Loading commit data...
sanitizer Loading commit data...
snapshot Loading commit data...
strings Loading commit data...
tasks Loading commit data...
third_party Loading commit data...
torque Loading commit data...
tracing Loading commit data...
trap-handler Loading commit data...
utils Loading commit data...
wasm Loading commit data...
zone Loading commit data...
DEPS Loading commit data...
OWNERS Loading commit data...