• Seth Brenith's avatar
    [tools] Add list of classes to v8_debug_helper · 4d0360aa
    Seth Brenith authored
    This change extends v8_debug_helper to export a new method that returns
    a list of all known heap object types.
    
    Why? We can substantially improve the user experience in our work-in-
    progress WinDbg extension if we register handlers not only for
    v8::internal::Object but for every specific HeapObject type. This has
    two benefits:
    
    - You save a click: if you're expanding a local variable of a more
      specific type than Object, you can see properties immediately rather
      than first needing to expand a sub-item that casts the variable to
      Object.
    - You retain the type hint: GetObjectProperties accepts a type hint
      string, and it's super important to pass it when working in a crash
      dump because the object's Map is probably inaccessible. If we have to
      cast to Object first, we lose this data.
    
    Bug: v8:9376
    Change-Id: I4d635a1826574a3d08ac657e848e1fe7b83849fe
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1822859Reviewed-by: 's avatarTobias Tebbi <tebbi@chromium.org>
    Reviewed-by: 's avatarJakob Gruber <jgruber@chromium.org>
    Commit-Queue: Seth Brenith <seth.brenith@microsoft.com>
    Cr-Commit-Position: refs/heads/master@{#64331}
    4d0360aa
Name
Last commit
Last update
benchmarks Loading commit data...
build_overrides Loading commit data...
custom_deps Loading commit data...
docs Loading commit data...
gni Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.clang-format Loading commit data...
.clang-tidy Loading commit data...
.editorconfig Loading commit data...
.flake8 Loading commit data...
.git-blame-ignore-revs Loading commit data...
.gitattributes Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.vpython Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
COMMON_OWNERS Loading commit data...
ChangeLog Loading commit data...
DEPS Loading commit data...
ENG_REVIEW_OWNERS Loading commit data...
INFRA_OWNERS Loading commit data...
INTL_OWNERS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
LICENSE.valgrind Loading commit data...
MIPS_OWNERS Loading commit data...
OWNERS Loading commit data...
PPC_OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
S390_OWNERS Loading commit data...
WATCHLISTS Loading commit data...
codereview.settings Loading commit data...