• Simon Zünd's avatar
    Fix crash in JSPromise::Resolve when 'then' getter is terminating · 4c28563b
    Simon Zünd authored
    The crash scenario is as follows:
      1) Add a getter for 'then' to the Object prototype that is
         considered side-effecting.
      2) Evaluate a simple string using 'REPL' mode with side-effect checks
         enabled.
         Note: REPL mode is not strictly necessary, but it causes a 'then'
         lookup as the evaluation result is not a promise.
      3) Calling the 'then' getter causes a termination exception, due
         to the side-effect check. JSPromise::Resolve then tries to
         put the termination exception as the reject reason, which causes
         a CHECK failure.
    
    The solution is to check for termination in the "abrupt completion"
    case when 'then' was retrieved.
    
    Bug: chromium:1140845
    Change-Id: I72b644cd49355cea40f599fcbe80264e99ed7bd6
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2501283Reviewed-by: 's avatarYang Guo <yangguo@chromium.org>
    Reviewed-by: 's avatarCamillo Bruni <cbruni@chromium.org>
    Commit-Queue: Simon Zünd <szuend@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#70785}
    4c28563b
Name
Last commit
Last update
build_overrides Loading commit data...
custom_deps Loading commit data...
docs Loading commit data...
gni Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.clang-format Loading commit data...
.clang-tidy Loading commit data...
.editorconfig Loading commit data...
.flake8 Loading commit data...
.git-blame-ignore-revs Loading commit data...
.gitattributes Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.vpython Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
COMMON_OWNERS Loading commit data...
DEPS Loading commit data...
DIR_METADATA Loading commit data...
ENG_REVIEW_OWNERS Loading commit data...
INFRA_OWNERS Loading commit data...
INTL_OWNERS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
MIPS_OWNERS Loading commit data...
OWNERS Loading commit data...
PPC_OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
S390_OWNERS Loading commit data...
WATCHLISTS Loading commit data...
codereview.settings Loading commit data...