• Bruce Dawson's avatar
    Workaround VS/UCRT fmod bug · 4bd1215c
    Bruce Dawson authored
    Recent versions of the Windows Universal CRT changed the behavior of
    fmod for when the first parameter is negative. In particular, a result
    of negative zero became positive zero. This is rarely critical but it
    causes test failures and may effect some JS test suites or web pages.
    
    The fix is to modify Modulo to check for a result of 0 when the first
    parameter is negative and change the result to -0. That fixes four of
    the five test failures and the fifth one is fixed by comparing the
    results against Modulo instead of std::fmod.
    
    Bug: chromium:915045
    Change-Id: Ia4490ec98361a37006d6c338acd33f959fa3ccea
    Reviewed-on: https://chromium-review.googlesource.com/c/1383091
    Commit-Queue: Bruce Dawson <brucedawson@chromium.org>
    Reviewed-by: 's avatarRoss McIlroy <rmcilroy@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#58377}
    4bd1215c
Name
Last commit
Last update
benchmarks Loading commit data...
build_overrides Loading commit data...
custom_deps Loading commit data...
docs Loading commit data...
gni Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.clang-format Loading commit data...
.clang-tidy Loading commit data...
.editorconfig Loading commit data...
.git-blame-ignore-revs Loading commit data...
.gitattributes Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.vpython Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
ChangeLog Loading commit data...
DEPS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
LICENSE.valgrind Loading commit data...
OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
WATCHLISTS Loading commit data...
codereview.settings Loading commit data...
snapshot_toolchain.gni Loading commit data...