• Benedikt Meurer's avatar
    [typedarray] Move external/data pointer to JSTypedArray. · 4b86fea5
    Benedikt Meurer authored
    As the next step in supporting huge typed arrays in V8, this moves the
    external/data pointer from the FixedTypedArrayBase backing store to the
    JSTypedArray instance itself, and replaces the special backing stores
    with a plain ByteArray (removing all the code for the FixedTypedArrayBase
    class hierarchy). By doing so, we can drastically simplify the system
    around typed arrays.
    
    Note: Several places in the code base used to check the instance type
    of the elements backing store of a JSTypedArray instead of checking the
    elements kind on the JSTypedArray map directly. Those had to be fixed,
    since the backing store is now always a ByteArray.
    
    Drive-by-fix: Move all the typed elements access related code into the
    elements.cc file to properly encapsulate the accesses.
    
    Doc: http://doc/1Z-wM2qwvAuxH46e9ivtkYvKzzwYZg8ymm0x0wJaomow
    Bug: chromium:951196, chromium:965583, v8:4153, v8:7881, v8:9183
    Change-Id: I8cc06b190c53e34155000b4560f5f3ef40621646
    Cq-Include-Trybots: luci.chromium.try:linux-rel,win7-rel
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1627535
    Commit-Queue: Benedikt Meurer <bmeurer@chromium.org>
    Reviewed-by: 's avatarPeter Marshall <petermarshall@chromium.org>
    Reviewed-by: 's avatarUlan Degenbaev <ulan@chromium.org>
    Reviewed-by: 's avatarSimon Zünd <szuend@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#61855}
    4b86fea5
Name
Last commit
Last update
benchmarks Loading commit data...
build_overrides Loading commit data...
custom_deps Loading commit data...
docs Loading commit data...
gni Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.clang-format Loading commit data...
.clang-tidy Loading commit data...
.editorconfig Loading commit data...
.git-blame-ignore-revs Loading commit data...
.gitattributes Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.vpython Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
COMMON_OWNERS Loading commit data...
ChangeLog Loading commit data...
DEPS Loading commit data...
ENG_REVIEW_OWNERS Loading commit data...
INFRA_OWNERS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
LICENSE.valgrind Loading commit data...
OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
WATCHLISTS Loading commit data...
codereview.settings Loading commit data...