• Seth Brenith's avatar
    Change key format for script cache · 4b1b7e29
    Seth Brenith authored
    This is a partial reland of https://crrev.com/c/3597106 including fixes
    from https://crrev.com/c/3654413
    
    Before this change, a script cache key is the same format as an eval
    cache key, which is a FixedArray containing:
    - The SharedFunctionInfo of the containing function
    - The source text
    - The language mode in which the code was parsed
    - The position in the source where eval was called
    
    After this change, a script cache key is a WeakFixedArray containing:
    - A weak pointer to the Script
    - The hash value of the source text
    
    This sets up for a subsequent change which can cause these keys to
    outlive their corresponding values (top-level SharedFunctionInfos)
    without leaking any memory beyond the key itself.
    
    Bug: v8:12808
    Change-Id: Ibdfe5d10eafe5b7392e554c500af47975baf45c6
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3668304Reviewed-by: 's avatarLeszek Swirski <leszeks@chromium.org>
    Commit-Queue: Seth Brenith <seth.brenith@microsoft.com>
    Cr-Commit-Position: refs/heads/main@{#80899}
    4b1b7e29
Name
Last commit
Last update
.github Loading commit data...
bazel Loading commit data...
build_overrides Loading commit data...
custom_deps Loading commit data...
docs Loading commit data...
gni Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.bazelrc Loading commit data...
.clang-format Loading commit data...
.clang-tidy Loading commit data...
.editorconfig Loading commit data...
.flake8 Loading commit data...
.git-blame-ignore-revs Loading commit data...
.gitattributes Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.mailmap Loading commit data...
.style.yapf Loading commit data...
.vpython Loading commit data...
.vpython3 Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.bazel Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
COMMON_OWNERS Loading commit data...
DEPS Loading commit data...
DIR_METADATA Loading commit data...
ENG_REVIEW_OWNERS Loading commit data...
INFRA_OWNERS Loading commit data...
INTL_OWNERS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
LOONG_OWNERS Loading commit data...
MIPS_OWNERS Loading commit data...
OWNERS Loading commit data...
PPC_OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
RISCV_OWNERS Loading commit data...
S390_OWNERS Loading commit data...
WATCHLISTS Loading commit data...
WORKSPACE Loading commit data...
codereview.settings Loading commit data...