• Seth Brenith's avatar
    [regexp] Better quick checks on loop entry nodes · 4b15b984
    Seth Brenith authored
    Like the predecessor change https://crrev.com/c/v8/v8/+/1702125 , this
    change is inspired by attempting to exit earlier from generated RegExp
    code, when no further matches are possible because any match would be
    too long. The motivating example this time is the following expression,
    which tests whether a string of Unicode playing cards has five of the
    same suit in a row:
    
    /([🂡-🂮]{5})|([🂱-🂾]{5})|([🃁-🃎]{5})|([🃑-🃞]{5})/u
    
    A human reading this expression can readily see that any match requires
    at least 10 characters (5 surrogate pairs), but the LoopChoiceNode for
    each repeated option reports its minimum distance to the end of a match
    as zero. This is correct, because the LoopChoiceNode's behavior depends
    on additional state (the loop counter). However, the preceding node, a
    SET_REGISTER action that initializes the loop counter, could confidently
    state that it consumes at least 10 characters. Furthermore, when we try
    to emit a quick check for that action, we could follow only paths from
    the LoopChoiceNode that are possible based on the minimum iteration
    count. This change implements both of those "could"s.
    
    I expect this improvement to apply pretty broadly to expressions that
    use minimum repetition counts and that don't meet the criteria for
    unrolling. In this particular case, I get about 12% improvement on the
    overall UniPoker test, due to reducing the execution time of this
    expression by 85% and the execution time of another similar expression
    that checks for n-of-a-kind by 20%.
    
    Bug: v8:9305
    
    Change-Id: I319e381743967bdf83324be75bae943fbb5dd496
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1704941
    Commit-Queue: Seth Brenith <seth.brenith@microsoft.com>
    Reviewed-by: 's avatarJakob Gruber <jgruber@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#62963}
    4b15b984
Name
Last commit
Last update
benchmarks Loading commit data...
build_overrides Loading commit data...
custom_deps Loading commit data...
docs Loading commit data...
gni Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.clang-format Loading commit data...
.clang-tidy Loading commit data...
.editorconfig Loading commit data...
.flake8 Loading commit data...
.git-blame-ignore-revs Loading commit data...
.gitattributes Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.vpython Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
COMMON_OWNERS Loading commit data...
ChangeLog Loading commit data...
DEPS Loading commit data...
ENG_REVIEW_OWNERS Loading commit data...
INFRA_OWNERS Loading commit data...
INTL_OWNERS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
LICENSE.valgrind Loading commit data...
MIPS_OWNERS Loading commit data...
OWNERS Loading commit data...
PPC_OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
S390_OWNERS Loading commit data...
WATCHLISTS Loading commit data...
codereview.settings Loading commit data...