• Sathya Gunasekaran's avatar
    [intl] Cache the last used formatter if possible · 4b139f76
    Sathya Gunasekaran authored
    Instead of caching only the default formatter, cache the last used
    formatter if possible.
    
    This is better because it's a common use case to create a formatter
    in a different language and reuse it a lot, rather than create
    several formatters in various languages.
    
    Running the following benchmark:
    ```
    let i = 0;
    
    function toLocaleString() {
      i++;
      return i.toLocaleString();
    }
    
    i = 0;
    function toLocaleStringWithLocale() {
      i++;
      return i.toLocaleString('en-US');
    }
    
    const functions = [toLocaleString, toLocaleStringWithLocale];
    
    for (const f of functions) {
      let start = performance.now();
      for (let i = 0; i < 10e5; i++) {
        f();
      }
      let end = performance.now();
      print(`${f.name}: ${end - start}`);
    }
    ```
    sees the following improvements:
    
    With this patch:
      toLocaleString: 384.292
      toLocaleStringWithLocale: 450.48900000000003
    
    Without this patch:
      toLocaleString: 341.952
      toLocaleStringWithLocale: 23439.694
    
    This a little over 50x improvement.
    
    Bug: chromium:926075
    Change-Id: I0e316e959c90243e175df985854832a7abddbf54
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2536461
    Commit-Queue: Sathya Gunasekaran  <gsathya@chromium.org>
    Reviewed-by: 's avatarToon Verwaest <verwaest@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#71188}
    4b139f76
Name
Last commit
Last update
build_overrides Loading commit data...
custom_deps Loading commit data...
docs Loading commit data...
gni Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.clang-format Loading commit data...
.clang-tidy Loading commit data...
.editorconfig Loading commit data...
.flake8 Loading commit data...
.git-blame-ignore-revs Loading commit data...
.gitattributes Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.vpython Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
COMMON_OWNERS Loading commit data...
DEPS Loading commit data...
DIR_METADATA Loading commit data...
ENG_REVIEW_OWNERS Loading commit data...
INFRA_OWNERS Loading commit data...
INTL_OWNERS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
MIPS_OWNERS Loading commit data...
OWNERS Loading commit data...
PPC_OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
S390_OWNERS Loading commit data...
WATCHLISTS Loading commit data...
codereview.settings Loading commit data...