• leszeks's avatar
    [ignition] Fix building lookup graph when search depth is 0 · 4ad35791
    leszeks authored
    In some (rare) cases, the context depth passed to a dynamic variable lookup can
    be zero. In these cases, the fast path for the lookup (i.e. load from context or
    global) can always be taken, as there is no need to search the current context.
    
    However, with no slow path checks, the bytecode graph builder had a null
    environment for the slow path, causing segfaults when this graph was built.
    
    This patch adds a null check for the slow path environment, and skips building
    the slow path if the environment is null.
    
    BUG=chromium:652186
    
    Review-Url: https://codereview.chromium.org/2385123002
    Cr-Commit-Position: refs/heads/master@{#39949}
    4ad35791
Name
Last commit
Last update
benchmarks Loading commit data...
build_overrides Loading commit data...
docs Loading commit data...
gni Loading commit data...
gypfiles Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party/binutils Loading commit data...
tools Loading commit data...
.clang-format Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
ChangeLog Loading commit data...
DEPS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
LICENSE.valgrind Loading commit data...
Makefile Loading commit data...
Makefile.android Loading commit data...
OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
WATCHLISTS Loading commit data...
codereview.settings Loading commit data...
snapshot_toolchain.gni Loading commit data...