• Yang Guo's avatar
    Revert "inspector: find magic comment using V8 scanner" · 4a96850a
    Yang Guo authored
    This reverts commit 1b3b808a.
    
    Reason for revert: crbug/879988
    
    TBR=kozy@chromium.org
    
    Original change's description:
    > inspector: find magic comment using V8 scanner
    >
    > Inspector tries to provide sourceURL and sourceMappingURL for scripts
    > with parser errors. Without this CL we convert source of each script
    > to inspector string and search for magic comment there. Some web sites
    > use pattern when they get some data from network and constantly try to
    > parse this data as JSON, in this case we do a lot of useless work.
    >
    > So we can parse magic comments on V8 side only for compilation errors
    > (excluding parse JSON errors), to do it we can reuse scanner by running
    > it on each potential comment.
    >
    > R=​alph@chromium.org,verwaest@chromium.org,yangguo@chromium.org
    >
    > Bug: chromium:873865,v8:7731
    > Cq-Include-Trybots: luci.chromium.try:linux_chromium_headless_rel;master.tryserver.blink:linux_trusty_blink_rel
    > Change-Id: I77c270fd0e95cd7b2c9ee4b7f72ef344bc1fa104
    > Reviewed-on: https://chromium-review.googlesource.com/1182446
    > Reviewed-by: Toon Verwaest <verwaest@chromium.org>
    > Reviewed-by: Alexei Filippov <alph@chromium.org>
    > Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#55280}
    
    TBR=alph@chromium.org,yangguo@chromium.org,kozyatinskiy@chromium.org,verwaest@chromium.org
    
    # Not skipping CQ checks because original CL landed > 1 day ago.
    
    Bug: chromium:873865, v8:7731, chromium:879988
    Change-Id: Ia7ac766e19f9b58562d9430811f10b25c4556a46
    Cq-Include-Trybots: luci.chromium.try:linux_chromium_headless_rel;master.tryserver.blink:linux_trusty_blink_rel
    Reviewed-on: https://chromium-review.googlesource.com/1202583
    Commit-Queue: Yang Guo <yangguo@chromium.org>
    Reviewed-by: 's avatarYang Guo <yangguo@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#55594}
    4a96850a
Name
Last commit
Last update
benchmarks Loading commit data...
build_overrides Loading commit data...
custom_deps Loading commit data...
docs Loading commit data...
gni Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.clang-format Loading commit data...
.editorconfig Loading commit data...
.git-blame-ignore-revs Loading commit data...
.gitattributes Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.vpython Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
ChangeLog Loading commit data...
DEPS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
LICENSE.valgrind Loading commit data...
OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
WATCHLISTS Loading commit data...
codereview.settings Loading commit data...
snapshot_toolchain.gni Loading commit data...