• Pierre Langlois's avatar
    [heap] Do not use V8_LIKELY on FLAG_disable_write_barriers. · 4a89c018
    Pierre Langlois authored
    FLAG_disable_write_barriers is a constexpr so the V8_LIKELY macro isn't
    necessary. Interestingly, it can also cause clang to warn that the code
    is unreachable, whereas without `__builtin_expect()` the compiler
    doesn't mind. See for example:
    
    ```
    constexpr bool kNo = false;
    
    void warns() {
      if (__builtin_expect(kNo, 0)) {
        int a = 42;
      }
    }
    
    void does_not_warn() {
      if (kNo) {
        int a = 42;
      }
    }
    ```
    
    Compiling V8 for arm64 with both `v8_disable_write_barriers = true` and
    `v8_enable_pointer_compression = false` would trigger this warning.
    
    Bug: v8:9533
    Change-Id: Id2ae156d60217007bb9ebf50628e8908e0193d05
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2534811Reviewed-by: 's avatarUlan Degenbaev <ulan@chromium.org>
    Reviewed-by: 's avatarGeorg Neis <neis@chromium.org>
    Commit-Queue: Pierre Langlois <pierre.langlois@arm.com>
    Cr-Commit-Position: refs/heads/master@{#71157}
    4a89c018
Name
Last commit
Last update
build_overrides Loading commit data...
custom_deps Loading commit data...
docs Loading commit data...
gni Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.clang-format Loading commit data...
.clang-tidy Loading commit data...
.editorconfig Loading commit data...
.flake8 Loading commit data...
.git-blame-ignore-revs Loading commit data...
.gitattributes Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.vpython Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
COMMON_OWNERS Loading commit data...
DEPS Loading commit data...
DIR_METADATA Loading commit data...
ENG_REVIEW_OWNERS Loading commit data...
INFRA_OWNERS Loading commit data...
INTL_OWNERS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
MIPS_OWNERS Loading commit data...
OWNERS Loading commit data...
PPC_OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
S390_OWNERS Loading commit data...
WATCHLISTS Loading commit data...
codereview.settings Loading commit data...