• Shu-yu Guo's avatar
    Reland "[heap] Skip weak heap objects when sharedness doesn't match" · 4a399719
    Shu-yu Guo authored
    This is a reland of commit 38767476
    
    Changes since revert: None, original failure was caused by another CL
    
    Original change's description:
    > [heap] Skip weak heap objects when sharedness doesn't match
    >
    > During marking, shared objects should not be marked when not
    > marking the shared heap (i.e. when not doing a shared GC).
    > Doing so is unsafe, as marking can race with sweeper threads
    > sweeping the shared heap. This CL adds the missing check on
    > weak object marking.
    >
    > Bug: v8:12687
    > Change-Id: I1e0b8ba6b09bbcf665e5ff0f6242ed88f543c1fa
    > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3583610
    > Reviewed-by: Dominik Inführ <dinfuehr@chromium.org>
    > Commit-Queue: Shu-yu Guo <syg@chromium.org>
    > Cr-Commit-Position: refs/heads/main@{#79964}
    
    Bug: v8:12687
    Change-Id: Ia24ff5daa4d37daf73391c0e577b086611c5e496
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3584600
    Owners-Override: Shu-yu Guo <syg@chromium.org>
    Reviewed-by: 's avatarShu-yu Guo <syg@chromium.org>
    Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
    Commit-Queue: Shu-yu Guo <syg@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#79971}
    4a399719
Name
Last commit
Last update
.github Loading commit data...
bazel Loading commit data...
build_overrides Loading commit data...
custom_deps Loading commit data...
docs Loading commit data...
gni Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.bazelrc Loading commit data...
.clang-format Loading commit data...
.clang-tidy Loading commit data...
.editorconfig Loading commit data...
.flake8 Loading commit data...
.git-blame-ignore-revs Loading commit data...
.gitattributes Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.mailmap Loading commit data...
.style.yapf Loading commit data...
.vpython Loading commit data...
.vpython3 Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.bazel Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
COMMON_OWNERS Loading commit data...
DEPS Loading commit data...
DIR_METADATA Loading commit data...
ENG_REVIEW_OWNERS Loading commit data...
INFRA_OWNERS Loading commit data...
INTL_OWNERS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
LOONG_OWNERS Loading commit data...
MIPS_OWNERS Loading commit data...
OWNERS Loading commit data...
PPC_OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
RISCV_OWNERS Loading commit data...
S390_OWNERS Loading commit data...
WATCHLISTS Loading commit data...
WORKSPACE Loading commit data...
codereview.settings Loading commit data...