• Jakob Gruber's avatar
    [compiler] Optionally apply an offset to stack checks · 4a16305b
    Jakob Gruber authored
    The motivation behind this change is that the frame size of an optimized
    function and its unoptimized version may differ, and deoptimization
    may thus trigger a stack overflow. The solution implemented in this CL
    is to optionally apply an offset to the stack check s.t. the check
    becomes 'sp - offset > limit'. The offset is applied to stack checks at
    function-entry, and is set to the difference between the optimized and
    unoptimized frame size.
    
    A caveat: OSR may not be fully handled by this fix since we've already
    passed the function-entry stack check. A possible solution would be to
    *not* skip creation of function-entry stack checks for inlinees.
    
    This CL: 1. annotates stack check nodes with the stack check kind, where
    kind is one of {function-entry,iteration-body,unknown}. 2. potentially
    allocates a temporary register to store the result of the 'sp - offset'
    in instruction selection (and switches input registers to 'unique'
    mode). 3. Applies the offset in code generation.
    
    Drive-by: Add src/compiler/globals.h for compiler-specific globals.
    
    Bug: v8:9534,chromium:1000887
    Change-Id: I257191c4a4978ccb60cfa5805ef421f30f0e9826
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1762521
    Commit-Queue: Jakob Gruber <jgruber@chromium.org>
    Reviewed-by: 's avatarGeorg Neis <neis@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#63701}
    4a16305b
Name
Last commit
Last update
..
api Loading commit data...
asmjs Loading commit data...
ast Loading commit data...
base Loading commit data...
builtins Loading commit data...
codegen Loading commit data...
common Loading commit data...
compiler Loading commit data...
compiler-dispatcher Loading commit data...
d8 Loading commit data...
date Loading commit data...
debug Loading commit data...
deoptimizer Loading commit data...
diagnostics Loading commit data...
execution Loading commit data...
extensions Loading commit data...
flags Loading commit data...
handles Loading commit data...
heap Loading commit data...
ic Loading commit data...
init Loading commit data...
inspector Loading commit data...
interpreter Loading commit data...
json Loading commit data...
libplatform Loading commit data...
libsampler Loading commit data...
logging Loading commit data...
numbers Loading commit data...
objects Loading commit data...
parsing Loading commit data...
profiler Loading commit data...
protobuf Loading commit data...
regexp Loading commit data...
roots Loading commit data...
runtime Loading commit data...
sanitizer Loading commit data...
snapshot Loading commit data...
strings Loading commit data...
tasks Loading commit data...
third_party Loading commit data...
torque Loading commit data...
tracing Loading commit data...
trap-handler Loading commit data...
utils Loading commit data...
wasm Loading commit data...
zone Loading commit data...
DEPS Loading commit data...
OWNERS Loading commit data...