• Ben L. Titzer's avatar
    Remove invalid DCHECKS in unwinding-info-writer · 49a526ac
    Ben L. Titzer authored
    The unwinding info writer was assuming that a block that had no initial
    state must be the start or end block. It was trying to check if the
    block was the start or end by asserting that the block had either
    no predecessors or no successors. Loop rotation breaks this assumption,
    since it can move a block from inside a loop to before the loop
    header, and the block can then be the "start" block. But since
    such a block has both predecessor(s) and a successor, the check was
    wrong.
    
    R=clemensh@chromium.org
    BUG=chromium:913844
    
    Change-Id: Ic24c67a822d510cb082f25608089d313c3459be8
    Reviewed-on: https://chromium-review.googlesource.com/c/1373770
    Commit-Queue: Ben Titzer <titzer@chromium.org>
    Reviewed-by: 's avatarClemens Hammacher <clemensh@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#58675}
    49a526ac
Name
Last commit
Last update
benchmarks Loading commit data...
build_overrides Loading commit data...
custom_deps Loading commit data...
docs Loading commit data...
gni Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.clang-format Loading commit data...
.clang-tidy Loading commit data...
.editorconfig Loading commit data...
.git-blame-ignore-revs Loading commit data...
.gitattributes Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.vpython Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
ChangeLog Loading commit data...
DEPS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
LICENSE.valgrind Loading commit data...
OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
WATCHLISTS Loading commit data...
codereview.settings Loading commit data...
snapshot_toolchain.gni Loading commit data...