• Ross McIlroy's avatar
    Reland: [Interpreter] Move BinaryOp Smi transformation into BytecodeGenerator."" · 496864f8
    Ross McIlroy authored
    This relands commit d3e9aade. The original CL was reverted speculatively but didn't cause the buildbot failure.
    
    Original change's description:
    > [Interpreter] Move BinaryOp Smi transformation into BytecodeGenerator.
    > 
    > Perform the transformation to <BinaryOp>Smi for Binary ops which take Smi
    > literals in the BytecodeGenerator. This enables us to perform the
    > transformation for literals on either side for commutative operations, and
    > Avoids having to do the check on every bytecode in the peephole optimizer.
    > 
    > In the process, adds Smi bytecode variants for all binary operations, adding
    >  - MulSmi
    >  - DivSmi
    >  - ModSmi
    >  - BitwiseXorSmi
    >  - ShiftRightLogical
    > 
    > BUG=v8:6194
    > 
    > Change-Id: If1484252f5385c16957004b9cac8bfbb1f209219
    > Reviewed-on: https://chromium-review.googlesource.com/466246
    > Commit-Queue: Ross McIlroy <rmcilroy@chromium.org>
    > Reviewed-by: Yang Guo <yangguo@chromium.org>
    > Reviewed-by: Michael Starzinger <mstarzinger@chromium.org>
    > Reviewed-by: Igor Sheludko <ishell@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#44477}
    
    TBR=rmcilroy@chromium.org,machenbach@chromium.org,yangguo@chromium.org,mstarzinger@chromium.org,mythria@chromium.org,v8-reviews@googlegroups.com,ishell@chromium.org
    # Not skipping CQ checks because original CL landed > 1 day ago.
    BUG=v8:6194
    
    Change-Id: I2ccaefa1ce58d3885f5c2648755985c06f25c1d8
    Reviewed-on: https://chromium-review.googlesource.com/472746Reviewed-by: 's avatarRoss McIlroy <rmcilroy@chromium.org>
    Commit-Queue: Ross McIlroy <rmcilroy@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#44511}
    496864f8
Name
Last commit
Last update
benchmarks Loading commit data...
build_overrides Loading commit data...
docs Loading commit data...
gni Loading commit data...
gypfiles Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.clang-format Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
ChangeLog Loading commit data...
DEPS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
LICENSE.valgrind Loading commit data...
Makefile Loading commit data...
Makefile.android Loading commit data...
OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
WATCHLISTS Loading commit data...
codereview.settings Loading commit data...
snapshot_toolchain.gni Loading commit data...