• jacob.bramley's avatar
    Reland r21101: "ARM64: use jssp for stack slots" · 48d726cd
    jacob.bramley authored
    The original implementation assumed that LPushArguments and
    LInvoke/Call* could be assumed to be exclusively sequential. However,
    this isn't always the case. For example, GenerateCallFunction pushes
    some arguments and then selects between HInvokeFunction and
    HCallFunction.
    
    This fixed implementation resets a pushed_arguments_ counter based on
    the argument_count() of the preceeding basic block, then tracks it
    per-instruction as before (except that now we maintain a count rather
    than a boolean flag).
    
    At the same time, since we now track exactly how many arguments have
    been pushed onto the stack, I was able to adjust the offset accordingly
    and use jssp for stack slots even when arguments have been pushed.
    
    BUG=
    
    Review URL: https://codereview.chromium.org/1038363002
    
    Cr-Commit-Position: refs/heads/master@{#29249}
    48d726cd
Name
Last commit
Last update
benchmarks Loading commit data...
build Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party/binutils Loading commit data...
tools Loading commit data...
.clang-format Loading commit data...
.gitignore Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.gn Loading commit data...
ChangeLog Loading commit data...
DEPS Loading commit data...
LICENSE Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
LICENSE.valgrind Loading commit data...
Makefile Loading commit data...
Makefile.android Loading commit data...
Makefile.nacl Loading commit data...
OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
WATCHLISTS Loading commit data...
codereview.settings Loading commit data...