• zhengxing.li's avatar
    X87: [wasm] Change the test case for Run_WasmCall_Float32Sub · 48bc9425
    zhengxing.li authored
      The reason is same as the CL #31808 (issue 1430943002, X87: Change the test case for X87 float operations), please refer: https://codereview.chromium.org/1430943002/
    
      Here is the key comments from CL #31808
      Some new test cases use CheckFloatEq(...) and CheckDoubleEq(...) function for result check. When GCC compiling the CheckFloatEq() and CheckDoubleEq() function, those inlined functions has different behavior comparing with GCC ia32 build and x87 build.
      The major difference is sse float register still has single precision rounding semantic. While X87 register has no such rounding precsion semantic when directly use register value.
      The V8 turbofan JITTed has exactly same result in both X87 and IA32 port.
    
      So we add the following sentence to do type case to keep the same precision for Run_WasmCall_Float32Sub.
      Such as: volatile float expect = *i +/- *j; // *i +/- *j, etc.
    
    BUG=
    
    Review URL: https://codereview.chromium.org/1561023002
    
    Cr-Commit-Position: refs/heads/master@{#33143}
    48bc9425
Name
Last commit
Last update
..
benchmarks Loading commit data...
cctest Loading commit data...
intl Loading commit data...
js-perf-test Loading commit data...
memory Loading commit data...
message Loading commit data...
mjsunit Loading commit data...
mozilla Loading commit data...
preparser Loading commit data...
promises-aplus Loading commit data...
simdjs Loading commit data...
test262 Loading commit data...
unittests Loading commit data...
webkit Loading commit data...
bot_default.gyp Loading commit data...
bot_default.isolate Loading commit data...
default.gyp Loading commit data...
default.isolate Loading commit data...
ignition.gyp Loading commit data...
ignition.isolate Loading commit data...
optimize_for_size.gyp Loading commit data...
optimize_for_size.isolate Loading commit data...