• Michael Lippautz's avatar
    cppgc-js: Fix snapshot node merging · 4853c3ad
    Michael Lippautz authored
    In Blink, WindowProxy may be referred from two diffrent JS wrapper
    objects during page refresh (same site navigation reusing parts of the
    DOM). In this intermediate state, the old frame state is not yet
    reclaimed while the new state is already being added.
    
    We would like to only merge nodes when there's a 1:1 relation between
    C++ and JS objects. Unfortunately, WindowProxy breaks that assumption
    in that the C++ object doesn't directly point to the wrapper. In
    addition, merging this case is important as otherwise detachedness
    would not be propagated to the Window object (JS wrapper) which is the
    main user of detachedness.
    
    The CL allows overriding merged nodes, picking a random merged state
    during pageload while still resulting in the regular snapshot behavior
    outside of reloading the same page.
    
    The proper fix is addressing chromium:1218404 and only create merged
    nodes when the back reference points to the same object.
    
    Bug: chromium:1241610
    Change-Id: Ie77b51a56ce90ef377124304bb025342a724c600
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3114139Reviewed-by: 's avatarAnton Bikineev <bikineev@chromium.org>
    Commit-Queue: Michael Lippautz <mlippautz@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#76453}
    4853c3ad
Name
Last commit
Last update
..
api Loading commit data...
asmjs Loading commit data...
ast Loading commit data...
base Loading commit data...
baseline Loading commit data...
bigint Loading commit data...
builtins Loading commit data...
codegen Loading commit data...
common Loading commit data...
compiler Loading commit data...
compiler-dispatcher Loading commit data...
d8 Loading commit data...
date Loading commit data...
debug Loading commit data...
deoptimizer Loading commit data...
diagnostics Loading commit data...
execution Loading commit data...
extensions Loading commit data...
flags Loading commit data...
handles Loading commit data...
heap Loading commit data...
ic Loading commit data...
init Loading commit data...
inspector Loading commit data...
interpreter Loading commit data...
json Loading commit data...
libplatform Loading commit data...
libsampler Loading commit data...
logging Loading commit data...
numbers Loading commit data...
objects Loading commit data...
parsing Loading commit data...
profiler Loading commit data...
protobuf Loading commit data...
regexp Loading commit data...
roots Loading commit data...
runtime Loading commit data...
sanitizer Loading commit data...
snapshot Loading commit data...
strings Loading commit data...
tasks Loading commit data...
third_party Loading commit data...
torque Loading commit data...
tracing Loading commit data...
trap-handler Loading commit data...
utils Loading commit data...
wasm Loading commit data...
web-snapshot Loading commit data...
zone Loading commit data...
DEPS Loading commit data...
DIR_METADATA Loading commit data...
OWNERS Loading commit data...