• Manos Koukoutos's avatar
    [wasm] Do not call CheckForException on every node · 47892136
    Manos Koukoutos authored
    Calling CheckForException through the BUILD macro for almost every
    invocation of WasmGraphBuilder from graph-builder-interface created
    multiple issues:
    - It generated an invalid graph with GetExceptionValues, resulting in
      us having to hack CallBuiltin().
    - It will generate multiple problems with wasm-gc operations.
    - It needlessly slowed down compilation.
    
    Changes:
    - Remove BUILD macro, call CheckForException directly only for function
      calls and throws.
    - Split CheckForException into a fast inline path and a slow non-inline
      one.
    - Move BUILD's DCHECK into CHECK_INTERFACE.
    - Add an early exit to Decode().
    - Since we do not need the hack anymore, implement CallBuiltin properly.
    
    Change-Id: I38e3c73e0af80894584ce37e2f3bfc90111ac54f
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2717304
    Commit-Queue: Manos Koukoutos <manoskouk@chromium.org>
    Reviewed-by: 's avatarThibaud Michaud <thibaudm@chromium.org>
    Reviewed-by: 's avatarClemens Backes <clemensb@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#73036}
    47892136
Name
Last commit
Last update
.github Loading commit data...
build_overrides Loading commit data...
custom_deps Loading commit data...
docs Loading commit data...
gni Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.clang-format Loading commit data...
.clang-tidy Loading commit data...
.editorconfig Loading commit data...
.flake8 Loading commit data...
.git-blame-ignore-revs Loading commit data...
.gitattributes Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.vpython Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
COMMON_OWNERS Loading commit data...
DEPS Loading commit data...
DIR_METADATA Loading commit data...
ENG_REVIEW_OWNERS Loading commit data...
INFRA_OWNERS Loading commit data...
INTL_OWNERS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
MIPS_OWNERS Loading commit data...
OWNERS Loading commit data...
PPC_OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
RISCV_OWNERS Loading commit data...
S390_OWNERS Loading commit data...
WATCHLISTS Loading commit data...
codereview.settings Loading commit data...