• machenbach's avatar
    Revert of [turbofan] Introduce CheckUnless. (patchset #1 id:1 of... · 46c21b2c
    machenbach authored
    Revert of [turbofan] Introduce CheckUnless. (patchset #1 id:1 of https://codereview.chromium.org/2080113002/ )
    
    Reason for revert:
    [Sheriff] Speculative revert: Seems to lead to devtools crashes:
    https://build.chromium.org/p/client.v8.fyi/builders/V8-Blink%20Win/builds/5259
    
    Original issue's description:
    > [turbofan] Introduce CheckUnless.
    >
    > Similarly to CheckIf, CheckUnless is a deoptimization without a specific
    > frame state. A frame state is assigned during effect-control linearization
    > (and CheckUnless is turned into DeoptimizeUnless).
    >
    > At the moment, the new operator is only used at one place in native context
    > specialization, but we should use it everywhere. The advantage of
    > CHeckUnless is that it avoids non-truncating uses of values by frame
    > states. This particular change is aimed at Octane's crypto, where this
    > enables to turn one NumberMultiply into Int32Mul, and thus improve
    > the score by more than 10% (it also needs minus zero truncation and
    > typing to be improved, but those CLs are already in flight).
    >
    > BUG=v8:4470
    > R=bmeurer@chromium.org
    >
    > Committed: https://crrev.com/85fde59d538e0dcaf461108086c2f7cf904f567a
    > Cr-Commit-Position: refs/heads/master@{#37085}
    
    TBR=bmeurer@chromium.org,jarin@chromium.org
    # Skipping CQ checks because original CL landed less than 1 days ago.
    NOPRESUBMIT=true
    NOTREECHECKS=true
    NOTRY=true
    BUG=v8:4470
    
    Review-Url: https://codereview.chromium.org/2078333002
    Cr-Commit-Position: refs/heads/master@{#37090}
    46c21b2c
Name
Last commit
Last update
benchmarks Loading commit data...
build_overrides Loading commit data...
docs Loading commit data...
gni Loading commit data...
gypfiles Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party/binutils Loading commit data...
tools Loading commit data...
.clang-format Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
ChangeLog Loading commit data...
DEPS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
LICENSE.valgrind Loading commit data...
Makefile Loading commit data...
Makefile.android Loading commit data...
Makefile.nacl Loading commit data...
OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
WATCHLISTS Loading commit data...
codereview.settings Loading commit data...
snapshot_toolchain.gni Loading commit data...