• Clemens Backes's avatar
    Fail earlier on FreePages · 205fb295
    Clemens Backes authored
    {FreePages} is never expected to fail, and each caller wraps the call in
    a CHECK macro. In order to learn more about failures, this CL moves the
    CHECK inside of {::FreePages}, to fail whenever the {PageAllocator}
    fails to free pages.
    
    As a next step, I'll audit our {PageAllocator} implementations to ensure
    that none of them return {false} for {FreePages}. Note that this is
    already the case for the gin platform (chromium).
    
    R=mlippautz@chromium.org
    
    Bug: v8:12656, chromium:1299735
    Change-Id: Ib61be6cc8da0110ead2db1ad005728bd061e0243
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3484321Reviewed-by: 's avatarMichael Lippautz <mlippautz@chromium.org>
    Reviewed-by: 's avatarLeszek Swirski <leszeks@chromium.org>
    Commit-Queue: Clemens Backes <clemensb@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#79248}
    205fb295
Name
Last commit
Last update
..
api Loading commit data...
asmjs Loading commit data...
assembler Loading commit data...
base Loading commit data...
codegen Loading commit data...
compiler Loading commit data...
compiler-dispatcher Loading commit data...
date Loading commit data...
debug Loading commit data...
diagnostics Loading commit data...
execution Loading commit data...
heap Loading commit data...
interpreter Loading commit data...
libplatform Loading commit data...
logging Loading commit data...
numbers Loading commit data...
objects Loading commit data...
parser Loading commit data...
profiler Loading commit data...
regexp Loading commit data...
regress Loading commit data...
runtime Loading commit data...
sandbox Loading commit data...
strings Loading commit data...
tasks Loading commit data...
torque Loading commit data...
utils Loading commit data...
wasm Loading commit data...
zone Loading commit data...
BUILD.gn Loading commit data...
DEPS Loading commit data...
avoid-windows-h-includes.cc Loading commit data...
run-all-unittests.cc Loading commit data...
test-helpers.cc Loading commit data...
test-helpers.h Loading commit data...
test-utils.cc Loading commit data...
test-utils.h Loading commit data...
testcfg.py Loading commit data...
unittests.status Loading commit data...