• Ali Ijaz Sheikh's avatar
    [heap] replace DisableInlineAllocationSteps with PauseAllocationObservers · 4623b822
    Ali Ijaz Sheikh authored
    * DisableInlineAllocationSteps was a blunt hammer added to work around
      tests that needed to avoid artificially lower limits imposed by
      observers. PauseAllocationObserversScope can properly disable step on
      a temporary basis.
    * Modify tests. Remove DisableInlineAllocationSteps.
    
    This exposed a bug in allocation observers: we were not doing a step
    when a fresh page is added.
    
    Fix this by moving the step into UpdateAllocationInfo. We should be
    doing a step (and keeping top_on_previous_step_ consistent) whenever
    we move move top(). UpdateAllocationInfo is the correct place for this
    rather than the callers of UpdateAllocationInfo.
    
    Bug: 
    Change-Id: I2edc238dc2e73bf9a2e9738c2a9b50efcac5cbf0
    Reviewed-on: https://chromium-review.googlesource.com/821052
    Commit-Queue: Ali Ijaz Sheikh <ofrobots@google.com>
    Reviewed-by: 's avatarUlan Degenbaev <ulan@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#50052}
    4623b822
Name
Last commit
Last update
benchmarks Loading commit data...
build_overrides Loading commit data...
docs Loading commit data...
gni Loading commit data...
gypfiles Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.clang-format Loading commit data...
.editorconfig Loading commit data...
.git-blame-ignore-revs Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.vpython Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
ChangeLog Loading commit data...
DEPS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
LICENSE.valgrind Loading commit data...
Makefile Loading commit data...
Makefile.android Loading commit data...
OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
WATCHLISTS Loading commit data...
codereview.settings Loading commit data...
snapshot_toolchain.gni Loading commit data...