• Shu-yu Guo's avatar
    [weakrefs] Hold unregister tokens weakly · 45bb4498
    Shu-yu Guo authored
    Change unregister tokens to be held weakly instead of strongly. This
    enables the use case for an object to be used as its own unregister
    token.
    
    To avoid using an ephemeron table, FinalizationGroup's key_map is
    changed to key off unregister tokens' identity hashes. Because hashes
    may collide, a single key list may rarely contain multiple tokens. When
    a FinalizationGroup WeakCell's token becomes unreachable, during GC, it
    is removed from the the doubly linked key list and removed from the key
    map if it had a unique key.
    
    Bug: v8:8179
    Change-Id: If88fd2ab196e3f9a287990ae345117a0abb2f04d
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1970493
    Commit-Queue: Shu-yu Guo <syg@chromium.org>
    Reviewed-by: 's avatarUlan Degenbaev <ulan@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#65532}
    45bb4498
Name
Last commit
Last update
build_overrides Loading commit data...
custom_deps Loading commit data...
docs Loading commit data...
gni Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.clang-format Loading commit data...
.clang-tidy Loading commit data...
.editorconfig Loading commit data...
.flake8 Loading commit data...
.git-blame-ignore-revs Loading commit data...
.gitattributes Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.vpython Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
COMMON_OWNERS Loading commit data...
DEPS Loading commit data...
ENG_REVIEW_OWNERS Loading commit data...
INFRA_OWNERS Loading commit data...
INTL_OWNERS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
LICENSE.valgrind Loading commit data...
MIPS_OWNERS Loading commit data...
OWNERS Loading commit data...
PPC_OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
S390_OWNERS Loading commit data...
WATCHLISTS Loading commit data...
codereview.settings Loading commit data...