• Clemens Hammacher's avatar
    [wasm] Fix patching of new jump tables · 45558d49
    Clemens Hammacher authored
    The {code_table_} only contains entries for the declared functions, and
    is indexed by a slot index. The {PatchJumpTableLocked} and
    {PatchJumpTablesLocked} functions on the other hand expected a function
    index (offset by the number of imported functions). From that it
    computes the slot index again.
    This translation was missing in one place. This CL fixes this by
    directly passing the slot index instead of the function index to these
    methods. In all locations, we computed the slot index anyway for
    addressing the code table.
    
    Drive-by: Use more unique_ptr for managing the {code_table_}. This
    avoids ever having to store raw pointers.
    
    R=ahaas@chromium.org
    
    Bug: v8:9477
    Change-Id: I81caa53b74da010aee5854879e98e82b7773098b
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1813742
    Commit-Queue: Clemens Hammacher <clemensh@chromium.org>
    Reviewed-by: 's avatarAndreas Haas <ahaas@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#63896}
    45558d49
Name
Last commit
Last update
benchmarks Loading commit data...
build_overrides Loading commit data...
custom_deps Loading commit data...
docs Loading commit data...
gni Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.clang-format Loading commit data...
.clang-tidy Loading commit data...
.editorconfig Loading commit data...
.flake8 Loading commit data...
.git-blame-ignore-revs Loading commit data...
.gitattributes Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.vpython Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
COMMON_OWNERS Loading commit data...
ChangeLog Loading commit data...
DEPS Loading commit data...
ENG_REVIEW_OWNERS Loading commit data...
INFRA_OWNERS Loading commit data...
INTL_OWNERS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
LICENSE.valgrind Loading commit data...
MIPS_OWNERS Loading commit data...
OWNERS Loading commit data...
PPC_OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
S390_OWNERS Loading commit data...
WATCHLISTS Loading commit data...
codereview.settings Loading commit data...