• vabr's avatar
    Report unexpected lexical decl also without destructuring · 454816f0
    vabr authored
    https://codereview.chromium.org/2694003002/ introduced
    "SyntaxError: Lexical declaration cannot appear in a single-statement context"
    for the case when let + desctructuring from a list happen.
    
    As was pointed out in https://codereview.chromium.org/2694003002/#msg18, the
    case without destructuring would also benefit from a better message: if a
    single statement is expected and "let identifier = ..." is seen, the error is
    indeed again that the lexical declaration is not a statement. However, the current
    error is "Unexpected identifier", because the parser tries to accept "let" as
    an identifier in an expression statement, and then gives up seeing the other
    identifier after "let".
    
    This CL ensures that the parser recognises the error properly and reports
    accordingly. It also renames the existing test, which contains destructuring,
    and adds the one with a non-destructuring lexical declaration.
    
    BUG=v8:5686
    
    Review-Url: https://codereview.chromium.org/2697193007
    Cr-Commit-Position: refs/heads/master@{#43275}
    454816f0
Name
Last commit
Last update
benchmarks Loading commit data...
build_overrides Loading commit data...
docs Loading commit data...
gni Loading commit data...
gypfiles Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.clang-format Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
ChangeLog Loading commit data...
DEPS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
LICENSE.valgrind Loading commit data...
Makefile Loading commit data...
Makefile.android Loading commit data...
OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
WATCHLISTS Loading commit data...
codereview.settings Loading commit data...
snapshot_toolchain.gni Loading commit data...