• Jakob Gruber's avatar
    [compiler] Allow deopts to slightly exceed the stack limit · 4547c5ef
    Jakob Gruber authored
    We recently extended function-entry stack checks by an offset
    representing the difference in optimized and unoptimized frame sizes,
    with the intent of avoiding stack overflows during deopts. Although
    the generated code is very efficient (just a single additional
    register subtraction, executed exactly once per call), perf impact
    is measurable.
    
    To avoid the overhead in most cases, this CL adds a stack slack,
    currently set to 256 bytes, by which deopts are allowed to exceed the
    real V8 stack limit. For function-entry stack checks with an offset
    less than stack slack, the offset is not applied and the more
    efficient version of the stack check is emitted.
    
    The V8 limit is chosen to be smaller than OS stack size (assumed to
    be at least 1 MB). This guarantee is upheld even with slack.
    
    Bug: chromium:1020989,v8:9534
    Change-Id: Idee2e7ad1fa7810bf086a9f72ce00a9717010310
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1910099Reviewed-by: 's avatarGeorg Neis <neis@chromium.org>
    Reviewed-by: 's avatarTobias Tebbi <tebbi@chromium.org>
    Commit-Queue: Jakob Gruber <jgruber@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#65025}
    4547c5ef
Name
Last commit
Last update
..
api Loading commit data...
asmjs Loading commit data...
ast Loading commit data...
base Loading commit data...
builtins Loading commit data...
codegen Loading commit data...
common Loading commit data...
compiler Loading commit data...
compiler-dispatcher Loading commit data...
d8 Loading commit data...
date Loading commit data...
debug Loading commit data...
deoptimizer Loading commit data...
diagnostics Loading commit data...
execution Loading commit data...
extensions Loading commit data...
flags Loading commit data...
handles Loading commit data...
heap Loading commit data...
ic Loading commit data...
init Loading commit data...
inspector Loading commit data...
interpreter Loading commit data...
json Loading commit data...
libplatform Loading commit data...
libsampler Loading commit data...
logging Loading commit data...
numbers Loading commit data...
objects Loading commit data...
parsing Loading commit data...
profiler Loading commit data...
protobuf Loading commit data...
regexp Loading commit data...
roots Loading commit data...
runtime Loading commit data...
sanitizer Loading commit data...
snapshot Loading commit data...
strings Loading commit data...
tasks Loading commit data...
third_party Loading commit data...
torque Loading commit data...
tracing Loading commit data...
trap-handler Loading commit data...
utils Loading commit data...
wasm Loading commit data...
zone Loading commit data...
DEPS Loading commit data...
OWNERS Loading commit data...